Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Looking solid 👍 This was a mostly code review. I'll take a deeper dive in the UI on the next pass.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Minor: Move this to the `// Reds` section. Also, is this just a new color in the designs? Or did you have to create it to meet a11y? Ideally, we could use the same red we've been using for error...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Minor: The pattern up to now has been to declare computeds like stores, compact, user permissions & "high-level" things near the top of the computed block; as a means of making it easier to find in...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Does this need the `compact` param?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Minor: Prefer color variables.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Same as earlier comment - existing patterns seem to be just as effective, and not require `any`. Also, making sure `this.watchFormInputs()` is excluded on purpose.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
`isLoading` is probably meant to observe a different store here.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Should these be removed?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Could this just be: `this.formData = reactive({...});`? This is what we do everywhere else and it would allow us to not need to declare the `any` type. Also, I noticed we aren't initiating `this...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Minor: Prefer well-described variable names; e.g. `file` (?) over `f`. Or looking closer, it may be that the array is an array of military affiliations; e.g. `affiliation` or `militaryAffiliations`.
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jsandoval81 opened a pull request on csg-org/CompactConnect
path-to-regexp dependency update
### Requirements List - `yarn install --ignore-engines` ### Description List - Address https://github.com/csg-org/CompactConnect/security/dependabot/63 ### Testing List - `yarn test:unit:a...
jsandoval81 created a branch on InspiringApps/JCC-CompactConnect
frontend/dependency-updates - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
jsandoval81 opened a pull request on csg-org/CompactConnect
Frontend/Fix pw input validation messages
### Requirements List - _None_ ### Description List - Move message augmentation to after message evaluation - Update frontend to match latest backend pw requirements (length only) - Add test...
jsandoval81 created a branch on InspiringApps/JCC-CompactConnect
frontend/pw-input-fix - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
jsandoval81 opened a pull request on csg-org/CompactConnect
Frontend/permission api updates
### Requirements List - _None_ ### Description List - Change compact-level `read` permission to `readPrivate` - Add state-level `readPrivate` permission - Omit compact permission in server p...
jsandoval81 pushed 4 commits to frontend/permission-api-updates InspiringApps/JCC-CompactConnect
- Frontend/hifi style (#419) ### Requirements List - _None_ ### Description List - Swapped out the existing lo-fi... b9bdfb3
- Feat/Transaction History Processing Workflow with Email Notifications (#420) This PR adds a new workflow for process... 455f758
- Remove mock resources from persistent stack (#421) This is part two of the mock resource cleanup. Now that the API a... 7ca275d
- Merge branch 'development' into frontend/permission-api-updates c2d6ce5
jsandoval81 pushed 1 commit to frontend/permission-api-updates InspiringApps/JCC-CompactConnect
- WIP: Permission API updates - Handle board ed conditional case - @todo: Merge latest development - @todo: Smoke test ... 6ae444c
jsandoval81 created a branch on InspiringApps/JCC-CompactConnect
frontend/permission-api-updates - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jsandoval81 pushed 1 commit to frontend/hifi-style InspiringApps/JCC-CompactConnect
- Re-enable compact selector 99f0b14
jsandoval81 pushed 1 commit to frontend/hifi-style InspiringApps/JCC-CompactConnect
- Hi-fi updates - Added compact selector to new nav - Added off-click for nav - Privilege purchase flow minor tuning up... 5f94458
jsandoval81 pushed 4 commits to frontend/hifi-style InspiringApps/JCC-CompactConnect