Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

jsandoval81

jsandoval81 created a review on a pull request on csg-org/CompactConnect

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
It gives cognito REST API access to the auth token. For instance, to allow the user to call the change-password API.

View on GitHub

jsandoval81 created a review on a pull request on csg-org/CompactConnect

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Added

View on GitHub

jsandoval81 created a review on a pull request on csg-org/CompactConnect

View on GitHub

jsandoval81 pushed 1 commit to frontend/account-page InspiringApps/JCC-CompactConnect

View on GitHub

jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.

View on GitHub

jsandoval81 pushed 1 commit to frontend/account-page InspiringApps/JCC-CompactConnect

View on GitHub

jsandoval81 created a branch on InspiringApps/JCC-CompactConnect

frontend/staff-user-invites - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
_UI testing find - just commenting here for a resolvable comment_ On the purchase screen, I noticed that any server errors are displayed at the top of the page. It took me a sec to realize that ...

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
_Testing find - just commenting here for a resolvable comment_ `yarn build` gives new warnings: ` WARNING Compiled with 5 warnings` It looks like those CSS build warnings that have trouble r...

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Probably don't need these empty lines between variable declarations. Also, minor, but I've been putting the `handleSubmit()` methods lower down than the `initFormInputs()` methods.

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
_UI testing find - just commenting here for a resolvable comment_ Also on the privilege-select screen, I noticed that the "Next" button becomes enabled as soon as the attestation modal appears. ...

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
_UI testing find - just commenting here for a resolvable comment_ I noticed that clicking the actual checkbox on the privilege-select screen doesn't appear to bubble up to cause the item to be s...

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
I think I'd prefer to handle these template values `{{}}` discretely, as in handling the existence & formatting in the computed props, rather than the template. My main reasons are 1) consistency o...

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Change literal `'select'` to a translation.

View on GitHub

jsandoval81 created a review on a pull request on csg-org/CompactConnect

View on GitHub

jsandoval81 pushed 2 commits to development InspiringApps/JCC-CompactConnect
  • Sprint PR hotfixes (#318) ### Description List - Addresses Josh's comments in the sprint PR that he wanted in a hot... 6cdf70f
  • fix conditional check for sandbox compact config upload (#322) Sandbox deployments should upload the configuration f... 18fb110

View on GitHub

jsandoval81 pushed 1 commit to frontend/account-page InspiringApps/JCC-CompactConnect

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
I'd probably be more tempted to handle it in the computed. I'd look to just add a `.map()` to the existing computed; or possibly create an additional computed if that's easier.

View on GitHub

jsandoval81 created a review on a pull request on csg-org/CompactConnect

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
I haven't come across a case yet where it's been necessary. It's only a small-ish sample size so far, but I'm also having trouble picturing a need for it. Can you describe the need a bit more? I...

View on GitHub

jsandoval81 created a review on a pull request on csg-org/CompactConnect

View on GitHub

jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Let's remove it and just use InputText for now. In your `validation` you can just use [`Joi.number()....`](https://joi.dev/api/?v=17.13.3#number)

View on GitHub

jsandoval81 created a review on a pull request on csg-org/CompactConnect

View on GitHub

jsandoval81 opened a pull request on csg-org/CompactConnect
Frontend/account page
### Requirements List - `yarn install --ignore-engines` ### Description List - Add a UserAccount component - Add a ChangePassword component - Add an Account page component - Add an Account ...
jsandoval81 pushed 1 commit to frontend/account-page InspiringApps/JCC-CompactConnect

View on GitHub

jsandoval81 created a comment on an issue on csg-org/CompactConnect
Closed in #193

View on GitHub

jsandoval81 closed an issue on csg-org/CompactConnect
Admins with Multiple Compacts Selects Compact upon login
## User Story ### Acceptance Criteria - When state administrators with multiple compacts log in, the order of priority for compacts will be Counseling, OT, then ASLP ### Discussion items ...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Should this (or something related) also reset the `selectedPrivilegesToPurchase` & `arePurchaseAttestationsAccepted` values?

View on GitHub

Load more