Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
@jlkravitz I created #279 to track this. There might be some additional items we want to update in that flow.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
@jusdino I think we might need to update this error to be a 403, rather than a 401. The frontend treats 401s as an invalid session and removes session tokens + sends the user back to login. @jlk...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
@jlkravitz I might need some more details since I'm not able to reproduce it. Are there any values in the state drop-down for the user you're logged in as? Do you still get the error if your local ...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
@jlkravitz I think that's the item we're addressing in #224 (in progress).
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review. _FYI the last 2 comments wouldn't present us the "mark as resolved" UI. Feel free to mark those as resolved if you have the permission._
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Now that this element is more expectedly interactive, a `cursor: pointer` might be in order.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
This might be easier as `@primaryColor` for now (which is black). That's what I've been using in anticipation that primary color will change globally (and hopefully easily) once we implement the hi...
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Really nice! Just a couple very minor style items remaining.
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Really nice! Just a couple very minor style items remaining.
jsandoval81 created a branch on InspiringApps/JCC-CompactConnect
frontend/a11y-table-voice-nav - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
jsandoval81 pushed 1 commit to frontend/staff-user-edit-permissions InspiringApps/JCC-CompactConnect
- Minor PR update 4808b41
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jsandoval81 pushed 1 commit to frontend/staff-user-edit-permissions InspiringApps/JCC-CompactConnect
- PR review updates 26b0606
jsandoval81 pushed 1 commit to frontend/staff-user-edit-permissions InspiringApps/JCC-CompactConnect
- PR review update 4e50d68
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
> Minor: Do we want to enable closing the modal on click off for the edit user permissions modal? There isn't notes on this in the design, but I initially wanted to _not_ have the off-click for ...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Yeah, these have changed somewhat frequently in the early days, and will continue to as API functionality changes. Having to often look them up from history would be a chore. I don't feel strongly ...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
This user-edit modal is less like a confirmation modal and more like a user-detail page. I didn't really need much of anything from our confirmation-style modal, I just needed a custom row UI that ...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
For a11y, lists are ideally semantically tagged, in this case ul / li.