Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jeaaustx opened a pull request on ibm-openbmc/bmcweb
Implement LocationIndicatorActive for PowerSupplies (#818)
Cherry-pick of upstream commit https://gerrit.openbmc.org/c/openbmc/bmcweb/+/42221 Tested using upstream flash image on hardware simulator. Implement LocationIndicatorActive for PowerSupplies...
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
Weird, that test isn't altered with this commit, right? I would think it would fail upstream also with the constexpr. Oh well, guess best to just leave as-is.
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
The upstream Description has roleId + " User Role". Should this case still have that?
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
Seems like if we leave this at line 2230 it would be one less potential future rebase merge conflict to deal with. I don't see userSelf being used before that line.
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
Can't this still be constexpr?
jeaaustx created a review on a pull request on ibm-openbmc/bmcweb
Looks good for rebase, I had just a couple of minor comments.
jeaaustx created a review on a pull request on ibm-openbmc/bmcweb
Looks good for rebase, I had just a couple of minor comments.
jeaaustx created a review on a pull request on ibm-openbmc/bmcweb
In the commit message there are two places that specify the new intervals. One is 5 times / 15 seconds in the paragraph. Bottom of the message matches the 4 times / 30 seconds here. For clarity bes...
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
Example of using object_path type to match just the last part of a path: [getValidChassisPath](https://github.com/ibm-openbmc/bmcweb/blob/7d56dde64a459a2d8a5a68e11638112787e4a682/redfish-core/incl...
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
Above on L1230-1231 we are setting the @odata.id value before doing the async D-Bus call. On failure that will be part of the response. I think for Redfish that is not supposed to be in the respons...
jeaaustx created a review on a pull request on ibm-openbmc/bmcweb
I think it will be helpful to include the command output or more details of the problem being fixed by this change in the commit message. It will help in later releases when this patch is being reb...
jeaaustx created a review on a pull request on ibm-openbmc/bmcweb
I think it will be helpful to include the command output or more details of the problem being fixed by this change in the commit message. It will help in later releases when this patch is being reb...
jeaaustx created a comment on a pull request on ibm-openbmc/phosphor-dbus-interfaces
Note: Downstream 1110 bmcweb uses the hard-coded path to total_power. So adding this interface will not break it. Future direction is to get the upstream bmcweb commit merged using this interface a...
jeaaustx opened a pull request on ibm-openbmc/phosphor-dbus-interfaces
Add new interface to define sensor purpose
A chassis can have a sensor which tracks the total power consumption. Clients such as bmcweb need a programmatic approach to finding the unique sensor from the chassis. A design discussion [1] i...
jeaaustx opened a pull request on ibm-openbmc/bmcweb
Audit Log: Correct logging of sessions
Changes to add the GenerateSecretKeyRequired incorrectly removed the audit logging for session creation. [1] Adding it back. Tested: Created session. Checked audit entry added using both ausear...
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
But neither of these (on line 2177 now) have the portId included. Am I missing it? 2177: ```asyncResp->res.jsonValue["@odata.id"] = boost::urls::format("/redfish/v1/Managers/{}/DedicatedNetwor...
jeaaustx created a review on a pull request on ibm-openbmc/bmcweb
Changes to Redfish.md are still needed to document the new properties being returned.
jeaaustx created a review on a pull request on ibm-openbmc/bmcweb
Changes to Redfish.md are still needed to document the new properties being returned.
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
I see that this will work, but it does with the understanding that getPrettyName() only uses the first element of the first pair. For upstream it seems like handleFanPath() would need to be alte...
jeaaustx created a review on a pull request on ibm-openbmc/bmcweb
I have one comment on how I think this would have to be done upstream. But looks okay to me for 1110.