Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
It has to do with how testable it is, multiple functions within one use case means all three need to be mocked and accounted for instead of just one, even if you needed only one of them. And it's h...
frigvid created a review on a pull request on frigvid/mob3000-group11
That this still has a myriad of basic style errors, which at this point is honestly disconcerting. Fixing these is a 15 minute job. 30 if you're slow. And they shouldn't be such a large problem in ...
frigvid created a review on a pull request on frigvid/mob3000-group11
That this still has a myriad of basic style errors at this point is honestly disconcerting. Fixing these is a 15 minute job. 30 if you're slow. And they shouldn't be such a large problem in the fir...
frigvid created a review comment on a pull request on frigvid/mob3000-group11
This file is quite large, and a lot of them are just components that aren't placed in the components package. If these are meant to be private components, then the functions need to be correctly ma...
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Composable strings should be string resources, not directly used. It impedes translations.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Composable strings should be string resources, not directly used. It impedes translations.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Function parameter is not documented in KDoc.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Indentation. `onClick`'s body is not indented properly.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Indentation. Multiline parameter lists that have their own body should be line shifted and indented.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Indentation. Additionally, if these are used in a `Composable`, then they should be extracted to string resources. Additionally, some may be incorrectly capitalized.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Incorrectly placed author KDoc property. Should come after parameter KDoc properties, and also should have a date property.