Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

frigvid

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
Incorrectly committed file. These should be git ignored.

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
Incorrectly committed file. These should be git ignored.

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
Incorrectly committed file. These should be git ignored.

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
This change still needs to be reverted. There shouldn't be necessary to bump the JDK. If you mean less device support is necessary for the code to work, please provide your reasoning behind this ch...

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11
This has a few more things that need to be fixed, and I assume a merge artifact. However, the user profile colors are still not fixed, [see this comment](https://github.com/frigvid/mob3000-group11/...

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
[Same issue as this one.](https://github.com/frigvid/mob3000-group11/pull/27/files#r1848024213)

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
Incorrect indentation. The way to indent these has been shown before. You do not indent the starting bracket, you indent the composable function inside the unit body. It's important to follow the K...

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
This has not been solved. Multiple parameters need to be indented.

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
This has not been solved.

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
This has not been solved.

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11
Had the time to run through another quick code review before bed, but most of these changes are minor indentation/spacing related. Almost at the finish line now. :)

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
Same as [with this comment](https://github.com/frigvid/mob3000-group11/pull/27/files#r1847357323). Since there are multiple parameters, it should be indented.

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
Same as [with this comment](https://github.com/frigvid/mob3000-group11/pull/27/files#r1847357323). Since there are multiple parameters, it should be indented.

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
Same as [with this comment](https://github.com/frigvid/mob3000-group11/pull/27/files#r1847359334). There's an additional space after the starting parenthesis.

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
Spacing. Should be: ```kotlin Card(colors = CardDefaults.cardColors(containerColor = MaterialTheme.colorScheme.primary)) { ``` (The space between `Card(` and `colors`).

View on GitHub

frigvid created a review on a pull request on frigvid/mob3000-group11

View on GitHub

frigvid created a review comment on a pull request on frigvid/mob3000-group11
Same as [with this comment](https://github.com/frigvid/mob3000-group11/pull/27/files#r1847357323). Since there are multiple parameters, it should be indented.

View on GitHub

Load more