Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dshiell created a review comment on a pull request on polymerdao/polymer-registry
I dont't think we need to verify dispatcher addresses. We may want to update the registry with CROSS_L2_PROVER_ADDRESS though
dshiell created a review on a pull request on polymerdao/polymer-registry
Not totally sure how this is used. Looks fine, but I think we should remove dispatcher and add cross_l2_prover checking.
dshiell created a review on a pull request on polymerdao/polymer-registry
Not totally sure how this is used. Looks fine, but I think we should remove dispatcher and add cross_l2_prover checking.
dshiell pushed 9 commits to main open-ibc/vibc-core-smart-contracts
dshiell closed a pull request on open-ibc/vibc-core-smart-contracts
Ds/validate event test
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced receipt parsing logic for improved accuracy in handling RLP-enc...
dshiell pushed 1 commit to ds/validate_event_test open-ibc/vibc-core-smart-contracts
- build contracts; bump version v4.0.21 0e66fa1
dshiell pushed 1 commit to ds/validate_event_test open-ibc/vibc-core-smart-contracts
- uncomment tests 74f372a
dshiell created a review comment on a pull request on open-ibc/vibc-core-smart-contracts
this fails compilation
dshiell created a review comment on a pull request on open-ibc/vibc-core-smart-contracts
i believe its the first byte after the result of mload which needs to skip the first 32 bytes (length) of the receiptRLP which is an RLPItem (i think) in the form {length, ptr}
dshiell pushed 1 commit to ds/validate_event_test open-ibc/vibc-core-smart-contracts
- fix missing type 0afd1af
dshiell pushed 1 commit to ds/validate_event_test open-ibc/vibc-core-smart-contracts
- forge fmt c43c8ee
dshiell pushed 1 commit to ds/validate_event_test open-ibc/vibc-core-smart-contracts
- strip typebyte from receipt if needed 1fb70b7
dshiell created a review comment on a pull request on polymerdao/optimism-dev
ah I see, thanks for explaining!
dshiell created a review comment on a pull request on open-ibc/vibc-core-smart-contracts
I guess it adds a tiny bit of extra "dapp" logic? Does it provide some other use?
dshiell created a review on a pull request on open-ibc/vibc-core-smart-contracts
lgtm, just a question on what `receiveTransmissionEvent` adds to the venus contract over the `receiveEvent` method.
dshiell created a review on a pull request on open-ibc/vibc-core-smart-contracts
lgtm, just a question on what `receiveTransmissionEvent` adds to the venus contract over the `receiveEvent` method.