Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
cpsievert opened a draft pull request on posit-dev/py-shiny-site
Updating chat component page
### TODO - [ ] Don't merge until the next release of py-shiny (> v1.2.1) - [ ] What should be our advice for surfacing tool calls in the UI?
cpsievert pushed 1 commit to chat-chatlas posit-dev/py-shiny-site
- First pass at updating chat component page for a chatlas world bd323ff
cpsievert pushed 1 commit to chat-chatlas posit-dev/py-shiny-site
- Revert "First pass at updating chat component page for a chatlas world" This reverts commit 961c3a6280eadd65a02bfc8f... 642b7f1
cpsievert pushed 1 commit to main posit-dev/py-shiny-site
- Revert "First pass at updating chat component page for a chatlas world" This reverts commit 961c3a6280eadd65a02bfc8f... 642b7f1
cpsievert created a branch on posit-dev/py-shiny-site
chat-chatlas - The documentation website for Shiny for Python
cpsievert pushed 1 commit to main posit-dev/py-shiny-site
- First pass at updating chat component page for a chatlas world 961c3a6
cpsievert created a comment on a pull request on rstudio/bslib
Looks great overall! Consider this approved when all suggestions are considered/addressed and if there's no new major code changes. I will be mostly away until the 10th, but if you have questions t...
cpsievert created a review comment on a pull request on rstudio/bslib
Any reason you're not using `sass::sass_file()`?
cpsievert created a review comment on a pull request on rstudio/bslib
Should we be throwing an error if version is less than 5?
cpsievert created a review comment on a pull request on rstudio/bslib
This is missing the font family value
cpsievert created a review comment on a pull request on rstudio/bslib
This is missing the font family value
cpsievert created a review comment on a pull request on rstudio/bslib
Also might be worth handling `calc()` more gracefully
cpsievert created a review comment on a pull request on rstudio/bslib
Does this need to be concerned with leading/trailing whitespace?
cpsievert created a review comment on a pull request on rstudio/bslib
For consistency sake, I'd be ok with using `abort()` over `stop()`
cpsievert created a review comment on a pull request on rstudio/bslib
```suggestion file.exists(path) && !dir.exists(path) } ```
cpsievert created a review comment on a pull request on rstudio/bslib
```suggestion # Same as tools::file_ext() path_ext <- function(path) { ```
cpsievert created a review comment on a pull request on rstudio/bslib
```suggestion } if (nzchar(ext)) { path <- dirname(path) } ```
cpsievert created a review comment on a pull request on rstudio/bslib
I'm also a little confused why `resolve_bs_preset()` needs to be changed at all?