Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
cpsievert pushed 2 commits to main posit-dev/chatlas
cpsievert pushed 1 commit to main posit-dev/chatlas
- Add chat.export() method; improve repr() & str() behavior 0155744
cpsievert created a review comment on a pull request on rstudio/shiny
```suggestion # with this because it only removes calls from the opposite side of the stack. ```
cpsievert created a review comment on a pull request on rstudio/shiny
Seems we can rid of this portion now?
cpsievert created a review comment on a pull request on rstudio/shiny
FWIW, it seems `rlang::hash()` could handle this and would be faster?
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Any chance this could be done with `.add_defaults()` and `.add_rules()` instead of `._insert_sass()`?
cpsievert created a review comment on a pull request on rstudio/bslib
Small nit you can ignore if you want -- stylistically I'd prefer this to be inlined into the `tagAppendAttributes()` call?
cpsievert created a review comment on a pull request on rstudio/bslib
Will this difference go away with #1145?
cpsievert created a review comment on a pull request on rstudio/bslib
Ok, yea, I see where you're coming from. Feel free to resolve this one
cpsievert created a review comment on a pull request on rstudio/bslib
Now that I look into this, I'm not sure this is precisely what we want because of this behavior: ```r > x <- list(a = 1, a = 2) > x $a [1] 1 $a [1] 2 > x[["a"]] <- 3 > x $a [1] 3 ...
cpsievert created a review comment on a pull request on rstudio/bslib
```suggestion # In this case, navbar[[1]] should now have 2 values for data-bs-theme: # One that we implicitly added based on type/inverse and one explictly # from the user. The use...
cpsievert created a review comment on a pull request on rstudio/bslib
```suggestion # navbar should be a tagList() with both the `<nav>` and `div.tab-content` # The attributes are for customizing the `<nav>` tag navbar[[1]] <- rlang::exec(tagAppendAttributes...
cpsievert created a review comment on a pull request on rstudio/bslib
```suggestion attribs <- navbar_options[["attribs"]] if (is.null(attribs)) { return(navbar) } ```
cpsievert created a comment on a pull request on rstudio/bslib
Before I dive into this, I just did a quick run of these examples with `main`, and it seems 1-3 currently work the way we want them to? I can see though that, for 4, the navbar color doesn't change...
cpsievert created a review comment on a pull request on rstudio/bslib
I think `navbar_options_apply_attribs()` could be easier to reason about if you assume that it gets passed a tag object and a list of attributes. ```suggestion navbar_options_apply_attribs(na...