Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

carbonated-niko

carbonated-niko pushed 3 commits to carbonated/dev carbonated-dev/o3de
  • Added internal update function 17e175f
  • Added check to ensure it wont update if its already set 69099ab
  • Merge pull request #331 from carbonated-dev/niko/slider MAD-16400 Updated the slider component to do callbacks when ... 57f3d6b

View on GitHub

carbonated-niko closed a pull request on carbonated-dev/o3de
MAD-16400 Updated the slider component to do callbacks when the value is set
## What does this PR do? Slider component wasnt properly handling update callbacks when updates happened. To fix this, I moved setvalue logic into a new setvalueinternal so the bus event could...
carbonated-niko created a review comment on a pull request on carbonated-dev/o3de
Thanks! Lgtm

View on GitHub

carbonated-niko created a review on a pull request on carbonated-dev/o3de

View on GitHub

carbonated-niko created a comment on a pull request on carbonated-dev/o3de
Additionally @alexeykostin please link the ticket in the PR in the future please

View on GitHub

carbonated-niko created a review comment on a pull request on carbonated-dev/o3de
Oh actually - could you remove the else here so you have both options (save, save and close)

View on GitHub

carbonated-niko created a review on a pull request on carbonated-dev/o3de

View on GitHub

carbonated-niko created a review on a pull request on carbonated-dev/o3de

View on GitHub

carbonated-niko opened a pull request on carbonated-dev/o3de
MAD-16400 Updated the slider component to do callbacks when the value is set
## What does this PR do? Slider component wasnt properly handling update callbacks when updates happened. To fix this, I moved setvalue logic into a new setvalueinternal so the bus event could...
carbonated-niko pushed 1 commit to niko/slider carbonated-dev/o3de
  • Added check to ensure it wont update if its already set 69099ab

View on GitHub