Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
bastilian opened a draft pull request on RedHatInsights/compliance-frontend
refactor(Policies): Remove GraphQL implementation
## Secure Coding Practices Checklist GitHub Link - https://github.com/RedHatInsights/secure-coding-checklist ## Secure Coding Checklist - [ ] Input Validation - [ ] Output Encoding - [ ] Aut...
bastilian created a branch on bastilian/compliance-frontend
v2_migration_clean - Frontend code for Insights Compliance
bastilian closed a pull request on RedHatInsights/frontend-components
chore(deps): Correct utils package deps
react-intl and redux mock store are used in the `TestWrapper` component and should be proper dependencies.
bastilian opened a pull request on RedHatInsights/compliance-frontend
fix(Tailorings): RHINENG-14520 - Fix export for wizard
This fixes the export for the Rules step in the "Create Policy" wizard. **How to test:** 1) Open the "Create Policy" wizard and advance to the Rules step 2) Try exporting the rules as JSON o...
bastilian created a branch on bastilian/compliance-frontend
RHINENG-14520 - Frontend code for Insights Compliance
bastilian pushed 1 commit to RHINENG-14557 bastilian/compliance-frontend
- feat(Tailorings): Implement group selection 721839e
bastilian pushed 1 commit to RHINENG-14557 bastilian/compliance-frontend
- feat(Tailorings): Implement group selection ae84d3c
bastilian pushed 1 commit to RHINENG-14557 bastilian/compliance-frontend
- feat(Tailorings): Implement group selection 469c1c7
bastilian created a review on a pull request on RedHatInsights/compliance-frontend
LGTM! Nice work! Thank you @gkarat!
bastilian created a review on a pull request on RedHatInsights/registration-assistant
LGTM! Thank you @johnsonm325!
bastilian created a comment on a pull request on RedHatInsights/insights-advisor-frontend
Nice refactor! ✨ There seem to be some minor issues, for example, the "Pathways" tab and the "Immutable ..." tab on the details both lead to broken pages. It might be that we need to updated the...
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
To elaborate a bit more. The function component function will end up in the options for the table hook(s). While `JSON.stringify` removes any such entry, when we use `useDeepCompareEffect`, it will...
bastilian created a comment on a pull request on RedHatInsights/insights-chrome
@adonispuente The `LOCAL_APPS` feature of the `fec` command is not deprecated, it is broken.
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
The way this was written with `function` is on purpose in order to not have an anonymous function.
bastilian created a review on a pull request on RedHatInsights/registration-assistant
LGTM! Thank you @johnsonm325!
bastilian created a review on a pull request on RedHatInsights/malware-detection-frontend
LGTM! Thank you @leSamo!
bastilian created a comment on a pull request on RedHatInsights/registration-assistant
@johnsonm325 Would you mind adding step by step instructions on how to test this? I've looked at the `/insights/connector/activation-keys` route, but nothing changed there. Where can I find the pla...
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
Watch out: "forEach() expects a synchronous function — it does not wait for promises. Make sure you are aware of the implications while using promises (or async functions) as forEach callbacks."[0]...
bastilian created a review on a pull request on RedHatInsights/insights-advisor-frontend
LGTM! Thank you @adonispuente!
bastilian created a review on a pull request on RedHatInsights/insights-inventory-frontend
LGTM! Thank you @adonispuente!
bastilian created a review on a pull request on RedHatInsights/compliance-frontend
LGTM! Thank you @adonispuente!
bastilian created a review comment on a pull request on RedHatInsights/registration-assistant
If we can not avoid hardcoding this, we should at least extract these strings and put them into a descriptive constant.
bastilian created a review comment on a pull request on RedHatInsights/registration-assistant
Why is this required? The store `init` function should already have the notificationsReducer initialised, does it not?
bastilian created a review comment on a pull request on RedHatInsights/registration-assistant
A for loop would be more appropriate here.