Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
Hm. That sounds sus. 🙃 Maybe we can look into this. There doesn't appear to be a default sorting set for the table, or the endpoint/query.
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
Patternfly uses in some places the name `rowData`, also for the expandable feature[0]. Maybe we can keep that terminology here as well. [0] https://www.patternfly.org/components/table/#expandable
bastilian created a review on a pull request on RedHatInsights/compliance-frontend
Awesome! Thank you @LightOfHeaven1994!
bastilian pushed 1 commit to master RedHatInsights/compliance-frontend
- chore: Add more Tailorings docs (#2368) * chore(docs): Move docs higher up * chore(docs): Add more docs related to ... fa20374
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
This relation is described in the "value overrides". "Rule values" is really just a collective term. It's the whole feature, not just one entity.
bastilian created a comment on a pull request on RedHatInsights/compliance-frontend
@LightOfHeaven1994 If you see prefixes or suffixes to function names, components, etc., like "V2" or "Rest" or "GraphQL" etc. feel free to remove them. For example, we can rename `useFetchSystemsV2...
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
I added a note on that to the "Profiles", since the tailorings will inherit that from them.
bastilian pushed 3 commits to tailorings_docs bastilian/compliance-frontend
bastilian created a review comment on a pull request on RedHatInsights/vulnerability-ui
If we extract this part into a single proper component, we can test the column in isolation, like any other component.
bastilian pushed 1 commit to tailorings_docs bastilian/compliance-frontend
- chore(docs): Add more docs related to Tailorings 9016842
bastilian pushed 1 commit to tailorings_docs bastilian/compliance-frontend
- chore(docs): Add more docs related to Tailorings 849d5ee
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
Yeah, something like that. I didn't want to change to much yet, but first just establish a common understanding and later go over and align everything with it.
bastilian pushed 1 commit to tailorings_docs bastilian/compliance-frontend
- chore(docs): Add more docs related to Tailorings b59ed99
bastilian pushed 4 commits to tailorings_docs bastilian/compliance-frontend
bastilian created a review on a pull request on RedHatInsights/sed-frontend
LGTM! Thank you @leSamo!
bastilian created a review on a pull request on RedHatInsights/vulnerability-ui
Tested and (i) + Tooltip show up as expected. Thank you @johnsonm325!
bastilian created a comment on a pull request on RedHatInsights/vulnerability-ui
> If someone has a clever way to test this We might be able to test tooltips with the `hover()` function in Jest: https://testing-library.com/docs/user-event/convenience/#hover
bastilian created a review comment on a pull request on RedHatInsights/vulnerability-ui
It might be better to put them within the `describe` to ensure the effects of these callbacks don't leak into other tests.
bastilian created a comment on a pull request on RedHatInsights/insights-inventory-frontend
@AsToNlele Do you know where the "extra slash" comes from? We should rather try to figure out how a user would get to the URL mentioned in the Jira and make sure that it doesn't add an unnecessary ...
bastilian pushed 1 commit to tailorings_docs bastilian/compliance-frontend
- chore(docs): Add more docs related to Tailorings f2031ce
bastilian pushed 1 commit to tailorings_docs bastilian/compliance-frontend
- chore(docs): Add more docs related to Tailorings fb0925b