Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
bastilian created a branch on bastilian/compliance-frontend
RHINENG-14557 - Frontend code for Insights Compliance
bastilian created a review on a pull request on RedHatInsights/compliance-frontend
LGTM! Thank you @LightOfHeaven1994!
bastilian created a review on a pull request on RedHatInsights/compliance-frontend
LGTM! Thank you @LightOfHeaven1994!
bastilian created a comment on a pull request on RedHatInsights/compliance-frontend
I now tested the "Create Policy" and there seems to be an issue with the value editing. I tried editing the same rule in the policy wizard and when clicking the ✔️, the spinner appears, but nothing...
bastilian created a comment on a pull request on RedHatInsights/compliance-frontend
🤦♂️ I tested the edit policy even though the title clearly says "Create Policy". :D
bastilian created a comment on a pull request on RedHatInsights/compliance-frontend
I patched up the `setUpdatedPolicy` to fix the null error, but it also seems that the values are not yet saved properly when the save of the edit modal is pressed.
bastilian created a comment on a pull request on RedHatInsights/compliance-frontend
@gkarat It looks like there is a small issue when trying to save the value. When I try to edit the "SSH Max authentication attempts" in the "Set SSH authentication attempt limit" rule clicking on t...
bastilian created a review on a pull request on RedHatInsights/compliance-frontend
Awesome work! Thank you @LightOfHeaven1994!
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
It might be nicer to have a wrapper component, in the `NoTailorings` component (file), similar to how it is in other components like here: https://github.com/RedHatInsights/compliance-frontend/blob...
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
You can enable this to be handled automatically with the `useTableState` option[0]. [0] https://github.com/RedHatInsights/compliance-frontend/blob/master/src/Utilities/hooks/api/useComplianceQue...
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
There is already a hook called "useProfiles" for this endpoint.
bastilian pushed 2 commits to disable_tree_select bastilian/compliance-frontend
bastilian created a comment on a pull request on RedHatInsights/compliance-frontend
@AsToNlele Nah, I think we can still have it available, but not allow any selection.
bastilian created a comment on a pull request on RedHatInsights/compliance-frontend
@gkarat @LightOfHeaven1994 Thanks both for reviewing and testing!
bastilian pushed 1 commit to disable_tree_select bastilian/compliance-frontend
- chore(Tailorings): Default to rows view and disable tree selecting 0c061ce
bastilian pushed 3 commits to disable_tree_select bastilian/compliance-frontend
- fix(rulesTable): Allow rules table to open multiple rule (#2287) Co-authored-by: Egor Shamardin <33912805+LightOfHea... c0979c8
- chore(deps): update konflux references (#2288) Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.... 5607c6f
- chore(Tailorings): Default to rows view and disable tree selecting 8f9a639
bastilian opened a pull request on RedHatInsights/compliance-frontend
chore(Tailorings): Default to rows view and disable tree selecting
## Secure Coding Practices Checklist GitHub Link - https://github.com/RedHatInsights/secure-coding-checklist ## Secure Coding Checklist - [ ] Input Validation - [ ] Output Encoding - [ ] Aut...
bastilian created a branch on bastilian/compliance-frontend
disable_tree_select - Frontend code for Insights Compliance
bastilian pushed 1 commit to master RedHatInsights/compliance-frontend
- feat(Tailorings): RHINENG-14333 - Implement "Selected filter" for rules tables (#2270) * feat(Tailorings): RHINENG-1... 8dfb621
bastilian closed a pull request on RedHatInsights/compliance-frontend
feat(Tailorings): RHINENG-14333 - Implement "Selected filter" for rules tables
This PR implements the "Selected Only" toggle for the `Tailorings` component. It can be enabled by passing the `enableSecurityGuideRulesToggle` prop. Additionally a `profiles` array can now be p...
bastilian pushed 12 commits to RHINENG-14333 bastilian/compliance-frontend
- feat(RHINENG-14417): system detail default filter (#2284) cf7771d
- feat(Tailorings): RHINENG-14333 - Implement "Selected filter" for rules tables 9d10feb
- fix(CreatePolicy): Fix issues with multiple minor os versions 24d9165
- feat(Tailorings): Add default sortBy for tailorings dcf5085
- fix(Tailorings): Fix rule loading for Policy Details f53cce6
- chore(Tailorings): Updated docs cab7d56
- chore(useQuery): Update docs 96235ed
- fix(usePolicyRulesList): Fix import 771aa1c
- fix(Tailorings): Fix loading ruleGroups and tree policy details 809edc1
- chore: Remove debug logging 10ef9ff
- chore(tests): Fix tests eb89ce2
- fix(Tailorings): Fix loading of rows view b3f8177
bastilian pushed 1 commit to RHINENG-14333 bastilian/compliance-frontend
- fix(Tailorings): Fix loading of rows view 8f83458
bastilian pushed 1 commit to RHINENG-14333 bastilian/compliance-frontend
- fix(Tailorings): Fix loading of rows view 6dedd65
bastilian created a comment on a pull request on RedHatInsights/compliance-frontend
@adonispuente Thank you for testing as well! The policy details rules should now once again load properly.
bastilian pushed 12 commits to RHINENG-14333 bastilian/compliance-frontend
- fix(PoliciesTableV2): Fix dataMap for Policies table (#2279) Co-authored-by: Adonis Puente <60629070+adonispuente@us... f550163
- fix(RHINENG-14406): Enable remediation on system details (#2282) Fixes https://issues.redhat.com/browse/RHINENG-1440... 7055117
- feat(Tailorings): RHINENG-14333 - Implement "Selected filter" for rules tables 154ece6
- fix(CreatePolicy): Fix issues with multiple minor os versions 096048e
- feat(Tailorings): Add default sortBy for tailorings f946ff6
- fix(Tailorings): Fix rule loading for Policy Details f25c71d
- chore(Tailorings): Updated docs 889bfcd
- chore(useQuery): Update docs 42f2251
- fix(usePolicyRulesList): Fix import 38d60ef
- fix(Tailorings): Fix loading ruleGroups and tree policy details 307f21e
- chore: Remove debug logging 4f975cf
- chore(tests): Fix tests a2c22fe