Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
bastilian created a review on a pull request on RedHatInsights/compliance-frontend
LGTM! It is functional. The only things I noticed are that the rule names are not bold and coloured red as they are on the GQL version and that the "failed rules" filter doesn't seem to be applied ...
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
The fetch functions in `useQuery` are all wrapped in `useCallback`, and we are using them in some places as dependencies where they behave normally. There may be something else that
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
It seems this default filter isn't showing up when the page is initially loaded.
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
We should still pass on the `onSelect` if it is a function.
bastilian pushed 1 commit to RHINENG-14333 bastilian/compliance-frontend
- feat(Tailorings): RHINENG-14333 - Implement "Selected filter" for rules tables 2dfddf0
bastilian pushed 1 commit to RHINENG-14333 bastilian/compliance-frontend
- feat(Tailorings): RHINENG-14333 - Implement "Selected filter" for rules tables cd2f52e
bastilian pushed 1 commit to RHINENG-14333 bastilian/compliance-frontend
- feat(Tailorings): RHINENG-14333 - Implement "Selected filter" for rules tables e1b8469
bastilian pushed 1 commit to RHINENG-14333 bastilian/compliance-frontend
- feat(Tailorings): RHINENG-14333 - Implement "Selected filter" for rules tables 6798702
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
Ah, I understand why.
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
Why is this needed? What dependency is causing issues?
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
This is basically duplicating what the `useReportTestResults` would return via the `useQuery` hook with `data`, `loading` and `error`.
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
Let's leave this out and try to fix the sorting in another separate PR and ensure the `useTableSort` hook returns always the expected index corresponding to the passed columns. This may fix the sor...
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
Let's use the Columns and Cells from the `RulesTable` imported like the other `RulesTable`s do. It should not be difficult to prepare the columns and cells for the REST API response or map them via...
bastilian created a branch on bastilian/compliance-frontend
RHINENG-14333 - Frontend code for Insights Compliance
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
The issue this is fixing, should better be fixed in the `columnOffset` function to consistently get the proper index.
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
Maybe this can use `children`. Same below. https://react.dev/learn/passing-props-to-a-component#passing-jsx-as-children
bastilian closed a pull request on RedHatInsights/compliance-frontend
feat(PolicyDetails): RHINENG-11701 - Use tailorings rule tree
## Secure Coding Practices Checklist GitHub Link - https://github.com/RedHatInsights/secure-coding-checklist ## Secure Coding Checklist - [ ] Input Validation - [ ] Output Encoding - [ ] Aut...
bastilian created a comment on a pull request on RedHatInsights/compliance-frontend
@gkarat @AsToNlele Thank you both for reviewing and testing! Most of the comments should be addressed. The pagination, sorting, issues and oddities we should take a look at separately. Again, I sti...
bastilian created a review comment on a pull request on RedHatInsights/compliance-frontend
And changed. :)