Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
added in [9328a44](https://github.com/AllenInstitute/biofile-finder/pull/354/commits/9328a44ecfedb6b82b1fedfbbaf73679dbb37633) <img width="500" alt="image" src="https://github.com/user-attachments...
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- add time selection for DateTime types 9328a44
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
I'm opening a separate ticket for this because the FluentUI TimePicker is imo too buggy to use (and the API does not match the component), so making our own is just as good of an option but will ho...
aswallace pushed 1 commit to feature/metadata-editing/create-mms-endpoint-logic AllenInstitute/biofile-finder
- trim value strings to prevent empty submits e5114f8
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
Another case of using the pattern but not necessarily being able to defend. I believe we expect to always receive at least the state of the data from a success response
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
This is a pattern used by all the http service methods that made sense to me before but which I'm now having trouble defending. My interpretation is that when axios rejects a call, it does not nece...
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
I'm not the author of this one so I may not have the right explanation, but I think it's a method of throwing custom error messages in chai?
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
Yes, this is for the status message component. The modal z-index is set by fluent, not us, so this comment is intended to note that the status message will be covered by the modal overlay. I can cl...
aswallace created a comment on a pull request on AllenInstitute/biofile-finder
> Is it legal to delete an annotation? Or set the value to null? Technically yes, passing an empty array as the values effectively deletes annotations when you use the MMS `put` endpoint. Howeve...
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
removed in [e885706](https://github.com/AllenInstitute/biofile-finder/pull/372/commits/e885706c8a2a107d4fd473cacbeb720e0c5c5088)
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
fixed in [e885706](https://github.com/AllenInstitute/biofile-finder/pull/372/commits/e885706c8a2a107d4fd473cacbeb720e0c5c5088)
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
removed in [e885706](https://github.com/AllenInstitute/biofile-finder/pull/372/commits/e885706c8a2a107d4fd473cacbeb720e0c5c5088)
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
removed in [e885706](https://github.com/AllenInstitute/biofile-finder/pull/372/commits/e885706c8a2a107d4fd473cacbeb720e0c5c5088)
aswallace pushed 1 commit to feature/metadata-editing/create-mms-endpoint-logic AllenInstitute/biofile-finder
- remove logic for getting metadata from MMS e885706
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
Just to be clear, this is currently working as is
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
Yes, currently we are only passing the annotations that we want to edit