Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
I'm fairly confident we want `PUT`. `PATCH` does not allow us to replace existing values for annotations. I've been testing on `PUT`, and while it does replace all values for a given annotation, it...
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
Yes, I temporarily kept both of them in for debugging purposes but at this point can be removed
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
I agree in theory, but running into some implementation bugs
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
Unfortunately yes, the date picker does not provide a time selector. This issue also exists in the AnnotationFilterForm
aswallace opened a draft pull request on AllenInstitute/biofile-finder
Create logic for editing metadata
placeholder description
aswallace pushed 2 commits to feature/metadata-editing/create-mms-endpoint-logic AllenInstitute/biofile-finder
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- remove bool assignment Co-authored-by: Sean LeRoy <[email protected]> 83709f3
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
This was deliberate; FluentUI was not registering the property correctly. I'm not able to replicate the bug now though, so will fix & keep an eye on it
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- fix double semicolon Co-authored-by: Sean LeRoy <[email protected]> c47206a
aswallace opened an issue on AllenInstitute/biofile-finder
Endpoint for adding new annotations/metadata
FMS: - Call the POST on the MMS endpoints to create a new annotation Non FMS: - Add logic to add new columns to duckDB? _Originally posted by @aswallace in https://github.com/AllenInstitute/...
aswallace pushed 51 commits to feature/metadata-editing/create-mms-endpoint-logic AllenInstitute/biofile-finder
- add bff bucket and cloudfront env 7cfb04c
- add bff bucket and cloudfront env 50061ef
- remove biofile-finder bucket 2f27df5
- clean up cc17430
- add comment to biofile-finder's CloudFront 5547c2a
- Merge pull request #358 from AllenInstitute/feature/bff Feature/bff 1d8f4e3
- typo, add bff echo 2169d8b
- typo 4f5fc11
- Merge pull request #359 from AllenInstitute/bugfix/typo typo b1b380a
- change bucket value 8a98e2b
- Merge pull request #360 from AllenInstitute/bugfix/bucket Change bucket value 12034b6
- gitignore mise configuration ac1aafd
- Merge pull request #362 from AllenInstitute/feature/mise-gitignore gitignore mise configuration 2934f07
- create new combobox component 61a9f95
- add edit option to file menu ce709d4
- add edit to modals 576ac13
- create edit metadata modal fc8d687
- fix styling for disabled buttons 4643411
- fix combobox attribute name fd7f333
- fix radio group font size dc7f4f8
- and 31 more ...
aswallace pushed 1 commit to feature/metadata-editing/create-mms-endpoint-logic AllenInstitute/biofile-finder
- add refresh for edits and account for annotations with spaces ca9b1c5
aswallace pushed 41 commits to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- add bff bucket and cloudfront env 7cfb04c
- add bff bucket and cloudfront env 50061ef
- remove biofile-finder bucket 2f27df5
- clean up cc17430
- add comment to biofile-finder's CloudFront 5547c2a
- Merge pull request #358 from AllenInstitute/feature/bff Feature/bff 1d8f4e3
- typo, add bff echo 2169d8b
- typo 4f5fc11
- Merge pull request #359 from AllenInstitute/bugfix/typo typo b1b380a
- change bucket value 8a98e2b
- Merge pull request #360 from AllenInstitute/bugfix/bucket Change bucket value 12034b6
- gitignore mise configuration ac1aafd
- Merge pull request #362 from AllenInstitute/feature/mise-gitignore gitignore mise configuration 2934f07
- create new combobox component 61a9f95
- add edit option to file menu ce709d4
- add edit to modals 576ac13
- create edit metadata modal fc8d687
- fix styling for disabled buttons 4643411
- fix combobox attribute name fd7f333
- fix radio group font size dc7f4f8
- and 21 more ...
aswallace pushed 29 commits to feature/metadata-editing/develop AllenInstitute/biofile-finder
- add bff bucket and cloudfront env 7cfb04c
- add bff bucket and cloudfront env 50061ef
- remove biofile-finder bucket 2f27df5
- clean up cc17430
- add comment to biofile-finder's CloudFront 5547c2a
- Merge pull request #358 from AllenInstitute/feature/bff Feature/bff 1d8f4e3
- typo, add bff echo 2169d8b
- typo 4f5fc11
- Merge pull request #359 from AllenInstitute/bugfix/typo typo b1b380a
- change bucket value 8a98e2b
- Merge pull request #360 from AllenInstitute/bugfix/bucket Change bucket value 12034b6
- gitignore mise configuration ac1aafd
- Merge pull request #362 from AllenInstitute/feature/mise-gitignore gitignore mise configuration 2934f07
- create new combobox component 61a9f95
- add edit option to file menu ce709d4
- add edit to modals 576ac13
- create edit metadata modal fc8d687
- fix styling for disabled buttons 4643411
- fix combobox attribute name fd7f333
- fix radio group font size dc7f4f8
- and 9 more ...
aswallace closed an issue on AllenInstitute/biofile-finder
ComboBox interaction bugs
The FluentUI component has a lot of interaction bugs identified by @lynwilhelm that need to be resolved: - [x] Clicking inside & typing still doesn't open open menu by default - [x] Add styling i...
aswallace pushed 5 commits to feature/metadata-editing/develop AllenInstitute/biofile-finder
- fix dropdown key bugs 5cab3f9
- add option to prevent modal from moving 9f72923
- remove fuse from dropdown to prevent buggy behavior 4d36246
- remove unrelated modal changes from branch 0c5c47a
- Merge pull request #355 from AllenInstitute/feature/metadata-editing/combobox-bugs Fix ComboBox (dropdown) bugs 861e40b
aswallace closed a pull request on AllenInstitute/biofile-finder
Fix ComboBox (dropdown) bugs
Addresses the following bugs specific to the ComboBox (FluentUI's version of a dropdown with search) - When the dropdown options were open, using arrow keys to navigate the options also changed th...
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
fixed in [761fa46](https://github.com/AllenInstitute/biofile-finder/pull/354/commits/761fa46a0c786142ff324d5007c58dc293e24b0b)
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- fix duration regex and add unit tests 761fa46
aswallace created a review on a pull request on AllenInstitute/biofile-finder
Makes sense to me to remove, React dev tools in electron haven't worked since at least when I joined. Do we foresee wanting to figure out how to get them working eventually?
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
these importants were not, in fact, important. Remnants of UI debugging. Removed in [b1d134a](https://github.com/AllenInstitute/biofile-finder/pull/354/commits/b1d134ad9a522f43a9135affb81e83607db8e...