Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
I may be misunderstanding the question, but users are not able to enter non-numeric values in this type of input (with the possible exception of `e`). I've added additional in-bounds validation in ...
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
good call, I'm used to thinking of max as exclusive. Fixed in [b1d134a](https://github.com/AllenInstitute/biofile-finder/pull/354/commits/b1d134ad9a522f43a9135affb81e83607db8eace)
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- add validation for in-bounds number inputs b1d134a
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
added in https://github.com/AllenInstitute/biofile-finder/pull/354/commits/1da0c7f16e2d21319ba164760615e2b8a5c7a1f7
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- add duration restrictions and file count check 1da0c7f
aswallace pushed 83 commits to feature/metadata-editing/create-mms-endpoint-logic AllenInstitute/biofile-finder
- feature/web-download-threshold 494a925
- Disable button for large zarrs on web 2b2ea66
- Upgrade regex to cover replaces 336a387
- Add missing await ea6a10d
- Use enum for pre-defined columns 71c3537
- Combine alter commands and add hidden UID 0ed66fa
- Use UID instead of File iD 6984110
- Use uid in more places bcb08dc
- Use hidden id in tests b7a1438
- Add canonical path back 09858bd
- Merge branch 'main' into feature/hide-unique-id-for-data-sources 8205802
- Improve data source prompt explanation 00af6b8
- Upgrade styling of csv example 2888c04
- Merge branch 'main' into feature/hide-unique-id-for-data-sources a431098
- Add tbody/thead 8f6e19b
- Simplify open with options 1882d24
- Prevent duplicate loading of same description source a543654
- Ensure change data source is called 7b3ab5e
- Use path not name edc7619
- Move comment 99d172e
- and 63 more ...
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
it should. I'll add a check for clarity though
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
Not currently, but I can add min/max restrictions on the UI
aswallace opened a pull request on AllenInstitute/biofile-finder
Feature/metadata editing/combobox bugs
Addresses the following bugs specific to the ComboBox (FluentUI's version of a dropdown with search) - When the dropdown options were open, using arrow keys to navigate the options also changed th...
aswallace pushed 1 commit to feature/metadata-editing/combobox-bugs AllenInstitute/biofile-finder
- remove unrelated modal changes from branch 0c5c47a
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- add option to prevent draggable modals a91c894
aswallace pushed 15 commits to feature/metadata-editing/combobox-bugs AllenInstitute/biofile-finder
- create new combobox component 8848542
- add edit option to file menu 576a6d9
- add edit to modals 35ca2bd
- create edit metadata modal 31fa439
- fix styling for disabled buttons 292bac7
- fix combobox attribute name add1d46
- fix radio group font size b59b67f
- fix alignment issues 5260743
- change file count to const f1a3987
- address styling bugs and PR feedback 66f7049
- warn user on exit with unsaved edits e7664b0
- swap render order for clarity 241cd67
- fix dropdown key bugs 5cab3f9
- add option to prevent modal from moving 9f72923
- remove fuse from dropdown to prevent buggy behavior 4d36246
aswallace pushed 1 commit to feature/metadata-editing/combobox-bugs AllenInstitute/biofile-finder
- remove fuse from dropdown to prevent buggy behavior 743e15a
aswallace created a comment on a pull request on AllenInstitute/biofile-finder
Thank you @lynwilhelm! Addressed feedback in [6c52646](https://github.com/AllenInstitute/biofile-finder/pull/354/commits/6c52646965a65d329630a4d0ffcdb9340c04a135) and updated the screenshots to ref...
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- address styling feedback 6c52646
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- right align number inputs 5d3e047
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- minor component fixes 91b74bd
aswallace opened a pull request on AllenInstitute/biofile-finder
Add custom input fields for editing metadata
This is a follow-up to #338 that adds custom fields for different data types based on [the Figma designs](https://www.figma.com/design/oNQvOAK11YINcbPvNmkgwO/Public-File-Explorer?node-id=3138-10352...
aswallace closed an issue on AllenInstitute/biofile-finder
Intercept onDismiss/exit in edit modal
When user tries to exist tab or dismiss the modal (by clicking outside or clicking x/cancel), intercept and render a warning modal letting them know the changes won't be saved Part of #96
aswallace pushed 17 commits to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- create new combobox component 8848542
- add edit option to file menu 576a6d9
- add edit to modals 35ca2bd
- create edit metadata modal 31fa439
- fix styling for disabled buttons 292bac7
- fix combobox attribute name add1d46
- fix radio group font size b59b67f
- fix alignment issues 5260743
- change file count to const f1a3987
- address styling bugs and PR feedback 66f7049
- warn user on exit with unsaved edits e7664b0
- swap render order for clarity 241cd67
- customize input field depending on data type 3a9d806
- create new components for duration and number inputs 7d08002
- add combobox for dropdown type dd0ae03
- respond to UX feedback for fields 3dea094
- update labels to match designs d8b3be5
aswallace pushed 2 commits to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
aswallace pushed 1 commit to feature/metadata-editing/combobox-bugs AllenInstitute/biofile-finder
- add option to prevent modal from moving 8c9585f
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- update labels to match designs ec58eda
aswallace pushed 1 commit to feature/metadata-editing/custom-input-fields AllenInstitute/biofile-finder
- respond to UX feedback for fields 4bf0f0b
aswallace pushed 12 commits to feature/metadata-editing/develop AllenInstitute/biofile-finder
- create new combobox component 8848542
- add edit option to file menu 576a6d9
- add edit to modals 35ca2bd
- create edit metadata modal 31fa439
- fix styling for disabled buttons 292bac7
- fix combobox attribute name add1d46
- fix radio group font size b59b67f
- fix alignment issues 5260743
- change file count to const f1a3987
- address styling bugs and PR feedback 66f7049
- warn user on exit with unsaved edits e7664b0
- swap render order for clarity 241cd67