Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Is the partial import intended?
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Not related to this change but we should update this to `MediaWiki\Title\Title`
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Same with above, should the return type be `Range` from `Elastica\Query\Range` instead?
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Should the return type be `Terms` from `Elastica\Query\Terms` instead of `AbstractQuery`?
alistair3149 pushed 1 commit to feat-item-label ProfessionalWiki/WikibaseFacetedSearch
- Remove unused todo f3a588b
alistair3149 pushed 12 commits to feat-item-label ProfessionalWiki/WikibaseFacetedSearch
- Use haswbfacet for parsing item type 658bc61
- Look for exact Property Id 1647e0d
- Add combined item type and values tests c74d809
- Use haswbfacet instead of haswbstatement for tabs f63fecf
- Hide facets when there are no facets Closes: #156 2ed1416
- Add .vscode to gitignore (#161) 89b2d97
- Do not render sidebar when it is empty (#160) * Do not render sidebar when it is empty Follow up to #159 * Dis... 3041f5f
- Revert "Add .vscode to gitignore (#161)" (#163) This reverts commit 89b2d97d5bd86f1d91daec402d8e9922ba7aeead. 4ef4d3e
- Add support for OR query in the Facet UI (#162) * Add support for OR query in the Facet UI #158 * Update funct... 87d6cd3
- Handle empty OR values (#167) a41a47f
- Fix incorrect label bottom margin in Chameleon The previous selector does not cover the modal 13f783f
- Merge branch 'master' into feat-item-label 3de83c0
alistair3149 pushed 1 commit to feat-item-label ProfessionalWiki/WikibaseFacetedSearch
- Fix lint issue 54d0287
alistair3149 pushed 1 commit to feat-item-label ProfessionalWiki/WikibaseFacetedSearch
- Refactor label handling with new FacetValueFormatter d780581
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
After seeing @malberts' comment and I agree that the value formatter is a more suitable approach. We do need to format other types of values into human readable formats. I will refactor the PR acco...
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
We can move the overflow rendering to the frontend. To do that, we need to hide the facets until the JS has set up the initial state of it. I prefer the PHP approach more because it is less render ...
alistair3149 pushed 2 commits to release-please--branches--main StarCitizenTools/mediawiki-skins-Citizen
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Yes that's right. I can refactor it into two functions in a follow up patch
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Yes normally there are always a selected button, this is used to deal with unexpected state as you mentioned
alistair3149 pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Handle empty OR values (#167) a41a47f
alistair3149 closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Handle empty OR values
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/166 * In general: removes empty values: `haswbfacet:p42=foo||bar` * Specific: allows a single OR value to be correctly parse...
alistair3149 created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
Would it be favorable if we use a query such as `haswbfacet:P1460=P1|` to notify the backend that it is in OR mode?
alistair3149 opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Fix incorrect label bottom margin in Chameleon
The previous selector does not cover the modal
alistair3149 created a branch on ProfessionalWiki/WikibaseFacetedSearch
fix-chameleon-label-margin - Enhanced searching interface with drilldown for Wikibase
alistair3149 opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add overflow handling for list facets
#79
alistair3149 created a branch on ProfessionalWiki/WikibaseFacetedSearch
feat-79 - Enhanced searching interface with drilldown for Wikibase
alistair3149 closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Revert "Add .vscode to gitignore"
Reverts ProfessionalWiki/WikibaseFacetedSearch#161