Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ThomThomson created a branch on ThomThomson/kibana
embeddableRefactor/synchronousSerialize - Your window into the Elastic Stack
ThomThomson created a review comment on a pull request on elastic/kibana
> because the by-ref saved object has already been saved Yet another example of why we need to fix this architecturally, as `save and return` on a by reference panel shouldn't even show `unsaved...
ThomThomson created a review comment on a pull request on elastic/kibana
Great to have a warning in this case. I wonder if we should clarify that the user needs to start a new session (open a new tab etc) to get their last saved state back?
ThomThomson created a review comment on a pull request on elastic/kibana
Do you think we should remove this typing after the architectural fix is in? I think this should be temporary because in theory, the `reset` function shouldn't be capable of failing.
ThomThomson created a review on a pull request on elastic/kibana
Changes LGTM as a temporary fix. It's great that the user cannot get into a broken state anymore, but we do still make it very difficult to get the last saved state back unfortunately. Left a few q...
ThomThomson created a review on a pull request on elastic/kibana
Changes LGTM as a temporary fix. It's great that the user cannot get into a broken state anymore, but we do still make it very difficult to get the last saved state back unfortunately. Left a few q...
ThomThomson created a review comment on a pull request on elastic/kibana
I don't think this is causing any problems with the PR, and I am able to render Canvas elements using these expression renderers in this PR with no problems. That said, I'd usually recommend _re...
ThomThomson created a review on a pull request on elastic/kibana
Changes to the Presentation team's theme providers and expression registrations LGTM. Tested locally in chrome, making sure our flyouts still apply theme arguments correctly, and ensuring that the ...
ThomThomson created a review on a pull request on elastic/kibana
Changes to the Presentation team's theme providers and expression registrations LGTM. Tested locally in chrome, making sure our flyouts still apply theme arguments correctly, and ensuring that the ...
ThomThomson created a review comment on a pull request on elastic/kibana
Ah, that makes sense - should've looked harder at the code.
ThomThomson created a review comment on a pull request on elastic/kibana
Any particular reason why you want to keep them separate? As I see it, the `settingsManager` manages state of type `DashboardOptions` and it's none of its concern that the `DashboardOptions` will e...
ThomThomson created a review comment on a pull request on elastic/kibana
It seems like a code-smell to me to initialize a behaviour subject then synchronously call `.next` on it instead of creating the behaviour subject with the initial value. That said, it's okay to ke...
ThomThomson created a review comment on a pull request on elastic/kibana
I'm not completely sure that's the right way to think about the controls as panels project, but you're right that we'll need to revisit this in the future anyway, so it's not worth the effort to re...
ThomThomson created a review comment on a pull request on elastic/kibana
If you did want to avoid this, you could potentially use an async function to wait for the control group to be created / assigned. I'd prefer to keep the subjects for items which are actually meant...
ThomThomson created a review comment on a pull request on elastic/kibana
Neat detail here that `managed` can't change anymore during the lifetime of the Dashboard API. I figure this is because the whole API is recreated every time the saved object ID changes. Good catch...
ThomThomson created a review on a pull request on elastic/kibana
This is a 🔥 great 🔥 collection of work, and so exciting to see the number of lines and files removed. Looked through the diff in github, and looked through the code structure in the IDE and everyth...
ThomThomson created a review on a pull request on elastic/kibana
This is a 🔥 great 🔥 collection of work, and so exciting to see the number of lines and files removed. Looked through the diff in github, and looked through the code structure in the IDE and everyth...
ThomThomson pushed 3933 commits to main ThomThomson/kibana
- Remove deprecated usages of `EuiFormRow`'s `display="columnCompressedSwitch"` prop (#198709) ## Summary This prop... 83a9acd
- [Data Usage] setup integration tests (#197112) ## Summary Adds serverless api integration tests and basic functio... 4f9ab47
- [Reporting] Remove "download CSV" export type functionality (#199033) ## Summary Closes https://github.com/elasti... 1df9479
- [unified-data-table] clean up another SASS compilation warnings (#199176) ## Summary Follows https://github.com/e... 437ca8b
- added '\' escapes (#199185) ## Summary This PR adds backslash escaping to previous code scan fixes. fb71142
- [Security Solution] Adds UI support for filtering by rule source customization (#197340) ## Summary Addresses htt... f740d95
- [ci] Remove plugin build (#197125) The platform plugin builds were used when functional tests were, at times, run f... 6b7c5b9
- skip flaky suite (#195672) 3a5fa5f
- [Docs] 8.15.4 release notes (#198565) ## Summary Adding a section for 8.15.4 release notes. --------- Co-au... bab2c2a
- skip flaky suite (#192128) 8e62f4e
- Add InfoSec team members as Ironbank project maintainers (#199148) Elastic's InfoSec organization has agreed to prov... 896b9c0
- [SecuritySolution] Change copy (#199160) ## Summary Change Entity Store enablement copy because it doesn't make s... 05bcf08
- [Security Solution][Notes] - disable note buttons in the right panel header when in preview mode (#199189) ## Summar... 53acbab
- [Dashboard] Remove modal for inter app from dashboard (#198619) ## Summary Closes https://github.com/elastic/kiba... 4f14c4a
- [Fleet] Improve input template API yaml comments (#199168) 8041372
- [Security Solution] Update rule link in cases activities (#198836) ## Summary As a follow up to https://github.co... 09dd66d
- Enable summarisation spec (#199134) This enables the api test that covers summarisation. It was originally skipped ... e399483
- [Canvas] Fix bug when trying to move elements (#199211) Closes https://github.com/elastic/kibana/issues/199110 ##... 1fa3089
- Skip claiming tasks that were modified during the task claiming phase (#198711) Resolves https://github.com/elastic/... a19dd8e
- [api-docs] 2024-11-07 Daily api_docs build (#199256) Generated by https://buildkite.com/elastic/kibana-api-docs-dail... a4adb56
- and 3913 more ...
ThomThomson created a review comment on a pull request on elastic/kibana
Yes this makes sense IMO. Solutions are expected to register embeddable types, and some of those will use drilldowns.
ThomThomson created a comment on a pull request on elastic/kibana
Woah, the easing function is such a cool detail!