Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
btw this def seems unused now
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
Alright found the logic in MMS, this is the logical path: https://github.com/AllenCellSoftware/metadata-management-service/blob/master/src/main/java/org/alleninstitute/aics/metadatamanagementservi...
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
I see... I think the request to get MMS "editable data" was to for insertion right here where this `annotations` parameter is. However, that is a very slow `GET` fetch so I don't think we should ne...
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
hmm... ig thats fine perhaps drop the TODO then?
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
```suggestion useComboBoxAsMenuWidth ```
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
Is there no time selector for `DATETIME` types or is there always a time selector for `DATE` types? Either of those would be bad no?
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
Seems like this component could exclusively pass around `Number` type values (for cases with leading zeroes it would just not yet return a value AKA `undefined`); NBD to keep this though
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
```suggestion width: 300px; ```
SeanLeRoy created a review on a pull request on bioio-devs/bioio-bioformats
At a glance it seems like the tests fail bc either bioformats got better at parsing channel names and we should adopt the new channel they output in our tests OR something is off about our parsing ...
SeanLeRoy created a review on a pull request on bioio-devs/bioio-bioformats
At a glance it seems like the tests fail bc either bioformats got better at parsing channel names and we should adopt the new channel they output in our tests OR something is off about our parsing ...
SeanLeRoy created a review on a pull request on AllenInstitute/biofile-finder
LGTM assuming we add the total file size count to the bottom of both tables as discussed in slack
SeanLeRoy created a review on a pull request on AllenInstitute/biofile-finder
It doesn’t seem like this PR is directly responsible, but I would prefer this change be entirely reverted if the issue I mentioned in slack below will continue. https://allencellscience.slack.co...
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
Might be good just to toss the error from the err.message here like ```suggestion interaction.actions.processError("moveFilesFailure", `Failed to cache files, details: ${(err as E...