Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
SeanLeRoy created a comment on an issue on AllenInstitute/biofile-finder
I don't think this is necessarily worth an issue - unlikely we would circle back to this without a motivator like a bug or new feature
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
> files were successfully cached. Files will be available in the NAS (VAST) after downloads finish asynchronously This reads like the "cache" & "NAS" are different things (as in we have past ten...
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
Are there other statuses possible? I wonder if it would make more sense to just keep a list of "success" statuses and if the status isn't in that list then it is considered a failure
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
"were successfully cached" is maybe misleading since this just kicks off the download process or refreshes it. I think something like "files will be available in the NAS after downloads finish asyn...
SeanLeRoy closed an issue on AllenInstitute/biofile-finder
Enable controlling the columns presented when sharing query
Yoav from AIBS wanted control over how users view their data, specifically what the columns shown are. This seems like something we could include in the query arguments like the groupings, filters,...
SeanLeRoy pushed 11 commits to main AllenInstitute/biofile-finder
- Improve no files found query message 412b724
- Remove light theme placeholder 70dc4aa
- Add columns to query args; Simplify state values 4ebfb32
- Fix potential NPE c7a33ea
- Merge branch 'main' into feature/add-better-column-control e847cce
- Update tests b2a8872
- Merge branch 'main' into feature/add-better-column-control 467ebf5
- Merge branch 'feature/add-better-column-control' of github.com:AllenInstitute/aics-fms-file-explorer-app into feature... a7e46d8
- Merge branch 'main' into feature/add-better-column-control 24479b9
- Fix typo fb8357e
- Merge pull request #337 from AllenInstitute/feature/add-better-column-control Feature/add better column control 0c4a83f
SeanLeRoy closed a pull request on AllenInstitute/biofile-finder
Feature/add better column control
## Description Users have wanted to control which columns are shown in shared queries for a while. This adds them to the query arguments decoded/encoded. While I was in here I noticed the colum...
SeanLeRoy pushed 1 commit to feature/add-better-column-control AllenInstitute/biofile-finder
- Fix typo fb8357e
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
Did you create a ticket for adding this capability for non-aics data sources? I think it wouldn't be very difficult to do via SQL like: ``` UPDATE ${datasourceName} SET ${columnToUpdate} = ${val...
SeanLeRoy created a review on a pull request on AllenInstitute/biofile-finder
Anya! You nailed this 💯
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
Unsure why I have never attached JS array functions onto the selector like this... looks clean!
SeanLeRoy created a review on a pull request on AllenInstitute/biofile-finder
Anya! You nailed this 💯
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
Oh I hadn't realized ".zarr/" would be a possibility. I bet I have to refactor some regex to account for this
SeanLeRoy created a review on a pull request on AllenInstitute/biofile-finder
I think an enum type could simplify a bit of this. Also, please please make sure none of the unit tests actually make network calls to FES that would be bad
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
oof will there ever be a day I don't have a typo
SeanLeRoy pushed 2 commits to feature/add-better-column-control AllenInstitute/biofile-finder
SeanLeRoy created a branch on AllenInstitute/biofile-finder
feature/improve-viewer-option-styling - An open-use web application created for easy access, collaboration, and sharing of datasets through rich metadata search, filter, sort, and direct viewing in common industry applications or in our web-based 3D Volume Viewer.
SeanLeRoy pushed 2 commits to feature/add-better-column-control AllenInstitute/biofile-finder
SeanLeRoy pushed 7 commits to feature/add-better-column-control AllenInstitute/biofile-finder
- Simplify open with options 1882d24
- Use path not name edc7619
- Merge branch 'feature/hide-unique-id-for-data-sources' into feature/simplify-open-with-options 6df4874
- Add empty list placeholder and dividers 97bf300
- Change message 4d50873
- Merge pull request #325 from AllenInstitute/feature/simplify-open-with-options Simplify open with options 646646c
- Merge branch 'main' into feature/add-better-column-control 467ebf5
SeanLeRoy closed an issue on AllenInstitute/biofile-finder
Make unsupported viewers clearer
We got some pushback during a meeting with AIBS today about the way we show possible viewers. They didn't think we discouraged users from clicking the wrong viewer / encourage them to click the rig...
SeanLeRoy pushed 6 commits to main AllenInstitute/biofile-finder
- Simplify open with options 1882d24
- Use path not name edc7619
- Merge branch 'feature/hide-unique-id-for-data-sources' into feature/simplify-open-with-options 6df4874
- Add empty list placeholder and dividers 97bf300
- Change message 4d50873
- Merge pull request #325 from AllenInstitute/feature/simplify-open-with-options Simplify open with options 646646c