Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

RenderMichael

RenderMichael pushed 5 commits to devtools-json RenderMichael/selenium
  • [java] Update dependency com.google.googlejavaformat:google-java-format to v1.25.2 (#14978) Co-authored-by: renovate... 1884d3f
  • [java] Update dependency org.redisson:redisson to v3.41.0 (#14983) Co-authored-by: renovate[bot] <29139614+renovate[... c6c60a7
  • [java] Update dependency rules_java to v7.12.4 (#14984) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.... 759bd6a
  • [grid] ensure --drain-after-session-count is respected with a lot of sessions in the queue (#14987) c826fec
  • Merge branch 'trunk' into devtools-json c914ea2

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
This is used all across cdp generated code. Luckily, the generated code looks like `var eventArgs = e.EventData.Deserialize(eventData.EventArgsType);` which is exactly the same when `EventData` is ...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael opened a pull request on SeleniumHQ/selenium
[dotnet] Switch DevTools response JSON parsing to `JsonElement`
**Thanks for contributing to Selenium!** **A PR well described will help maintainers to quickly review and merge it** Before submitting your PR, please check our [contributing](https://github.c...
RenderMichael created a branch on RenderMichael/selenium

devtools-json - A browser automation framework and ecosystem.

RenderMichael pushed 16 commits to trunk RenderMichael/selenium
  • [dotnet] Update dependency rules_dotnet to v0.17.5 (#14970) * [dotnet] Update dependency rules_dotnet to v0.17.5 ... 565bef9
  • [dotnet][java][js][py][rb][rust] Update dependency aspect_bazel_lib to v2.10.0 (#14971) Co-authored-by: renovate[bot... 73cc46e
  • [dotnet][java][js][py][rb][rust] Update dependency bazel_features to v1.23.0 (#14974) Co-authored-by: renovate[bot] ... 70b8cb7
  • [rust] Update Rust crate anyhow to v1.0.95 (#14955) * [rust] Update Rust crate anyhow to v1.0.95 * Repin dependen... acb3422
  • [rust] Update Rust crate serde_json to v1.0.134 (#14960) * [rust] Update Rust crate serde_json to v1.0.134 * Repi... 9eb9d82
  • [rust] Update Rust crate reqwest to v0.12.11 (#14959) * [rust] Update Rust crate reqwest to v0.12.11 * Repin depe... 1430320
  • [rust] Update Rust crate env_logger to v0.11.6 (#14958) * [rust] Update Rust crate env_logger to v0.11.6 * Repin ... cf4fb24
  • [rust] Update bazel lock file 695576a
  • [rust] Bump crates to latest versions 03146da
  • [grid] rework the retry of http requests #14917 (#14924) Co-authored-by: Diego Molina <[email protected]> 93483c5
  • [ci] Reducing the days for a stale issue 6 months is enough d84fb38
  • [grid] added missing locks related to health checks 95d67c3
  • [grid] removed a misleading lock from the grid model 18087e2
  • [grid] ensure the current session count is correct 9c9cd27
  • [dotnet][java][js][py][rb][rust] Update dependency bazel to v7.4.1 (#14973) * [dotnet][java][js][py][rb][rust] Updat... c6da9f7
  • [dotnet][java][js][py][rb][rust] Update dependency protobuf to v29.2 (#14976) Co-authored-by: renovate[bot] <2913961... e7f5524

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I found a workaround, with a custom converter. We can add to the postData property: ![image](https://github.com/user-attachments/assets/6a5630c0-1aea-4ea5-828e-1534b6959f17) As well as to ...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I narrowed down the issue. It looks like this character [`U+DB40`](https://unicodeplus.com/U+DB40) is appearing here for some reason. It is the first part of a surrogate pair (representing a charac...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I tried switching from `JsonNode` to `JsonElement` just to see what would happen. Good news, no exceptions on `ToString()` like the logging has, but the de-serialization still fails ![image](ht...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I do not understand how Newtonsoft accepts this nonsense input. It’s not real JSON, just some raw binary data. Maybe we should intersept the post data and sanitize it ourselves?

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a comment on a pull request on SeleniumHQ/selenium
I'm not sure if this is considered a full fix, it just moves the exception down Before: ![image](https://github.com/user-attachments/assets/e7602b6e-2feb-4b6a-9c4e-cfc14c3c0a52) After: ![image...

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
@nvborisenko You mentioned trying out `JavaScriptEncoder.UnsafeRelaxedJsonEscaping`. I cannot edit the generated code directly but I added a spoof here, and it did not fix the exception ![image](h...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
This is not a complete solution, the JSON exception is simply thrown later: ![image](https://github.com/user-attachments/assets/54d22891-71b8-42b0-a39d-af60929b3c7c) The above is in generated ...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Fundamentally, this error happens because the string resembles JSON, but is in fact not JSON ![image](https://github.com/user-attachments/assets/ed29be9e-4282-41a0-a659-271836ddff8f)

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael opened a pull request on SeleniumHQ/selenium
[dotnet] Avoid exceptions in cdp logging on file upload
**Thanks for contributing to Selenium!** **A PR well described will help maintainers to quickly review and merge it** Before submitting your PR, please check our [contributing](https://github.c...
RenderMichael created a branch on RenderMichael/selenium

devtools-file-upload - A browser automation framework and ecosystem.

RenderMichael pushed 13 commits to trunk RenderMichael/selenium
  • [rb] Adding doc link Credit to @jjb Closes #14897 db5c5c3
  • [ci] Running format script 50cbca9
  • py: Ensure DRIVER_PATH_ENV_KEY defaults to string (#14862) [py] Avoid os.getenv error if driver_path_env_key is not ... 33c6706
  • [dotnet] Do not intercept exceptions from `ICommandExecutor.ExecuteAsync` (#14892) 1545600
  • [py] remove xfail attr for firefox and safari for cookie tests (#14794) [py] remove xfail attr for firefox and safar... d1f9874
  • [java] Added a check for intentionally existing loggers (#14754) Added a check for intentionally existing loggers ... 16b0074
  • [js] Removing TODO Closes #14490 7681ebc
  • [js] Update dependency react-modal to v3.16.3 (#14951) * [js] Update dependency react-modal to v3.16.3 * Repin de... b19a5d0
  • [js] Update dependency esbuild to v0.24.2 (#14948) * [js] Update dependency esbuild to v0.24.2 * Repin dependenci... 7062b65
  • [js] Update dependency rules_nodejs to v6.3.2 (#14952) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.n... de88a12
  • [grid] use a single event listener for the event-bus health check 269a7f6
  • [java] JSpecify annotations for immutable models and enums (#14395) Co-authored-by: Puja Jagani <puja.jagani93@gmail... b60fb8e
  • [java] JSpecify annotations for wrappers (#14396) Co-authored-by: Puja Jagani <[email protected]> Co-authored... 045ce40

View on GitHub

RenderMichael pushed 80 commits to httpCommandExecutor RenderMichael/selenium
  • [dotnet] Modernize `Response` type (#14839) abb8440
  • [dotnet] Add nullability to Logs API (#14875) 623c4aa
  • [java] include the exit code to the error message of a failed driver startup cc58a4e
  • [py] add execute_cdp_cmd to Remote (#14809) * [py] add execute_cdp_cmd to Remote * use inherited method 4bb5353
  • [java] SpotBugs exclude `IS2_INCONSISTENT_SYNC` form the `SeleniumManager` (#14768) 9d68245
  • [java] Enable SpotBugs for java_export (#14882) f697509
  • [rust] Bump Selenium Manager version 71db187
  • [rust] Bump SM crates and rules_rust to the latest versions 3f3fd78
  • [dotnet] Add nullability to `CookieJar` (#14874) 28e9a3a
  • [dotnet] Refactor away private constructor from `Response` (#14877) 0174bce
  • [dotnet] Add nullability to `Alert`s (#14669) 6442f61
  • [rust] Fix Edge updates API deserialization (#14851) * [selenium manager]: fix edge artifact deserialisation * ad... 622cb43
  • [grid] decrement the connection per session counter on close #14842 (#14854) 4ea71ca
  • [bazel]: Bump `rules_protobuf` to avoid warning about `maven` namespace (#14891) 7cde7f8
  • [bazel]: Prepare for bump of `rules_closure` (#14890) Future updates to `rules_closure` remove the handy `closure/li... 2cc530d
  • [bazel] Switch to rules_closure 0.12.0 (#14895) 744e7d6
  • [rb] BiDi Network: add_request_handler, remove_request_handler, clear_request_handlers (#14751) * Start the work on ... 89b84ae
  • [dotnet] [bidi] Convert RemoteRefrence to an interface daf7356
  • [dotnet] [bidi] Convert RemoteObjectReference to an interface 19b7b5d
  • [dotnet] [bidi] Fix name of autodetect proxy configuration e6d6e0b
  • and 60 more ...

View on GitHub

RenderMichael pushed 1 commit to firefox-entensions RenderMichael/selenium
  • Handle when applications/gecko.id is all-whitespace 9e0a26b

View on GitHub

RenderMichael pushed 12 commits to firefox-entensions RenderMichael/selenium
  • [rb] Adding doc link Credit to @jjb Closes #14897 db5c5c3
  • [ci] Running format script 50cbca9
  • py: Ensure DRIVER_PATH_ENV_KEY defaults to string (#14862) [py] Avoid os.getenv error if driver_path_env_key is not ... 33c6706
  • [dotnet] Do not intercept exceptions from `ICommandExecutor.ExecuteAsync` (#14892) 1545600
  • [py] remove xfail attr for firefox and safari for cookie tests (#14794) [py] remove xfail attr for firefox and safar... d1f9874
  • [java] Added a check for intentionally existing loggers (#14754) Added a check for intentionally existing loggers ... 16b0074
  • [js] Removing TODO Closes #14490 7681ebc
  • [js] Update dependency react-modal to v3.16.3 (#14951) * [js] Update dependency react-modal to v3.16.3 * Repin de... b19a5d0
  • [js] Update dependency esbuild to v0.24.2 (#14948) * [js] Update dependency esbuild to v0.24.2 * Repin dependenci... 7062b65
  • [js] Update dependency rules_nodejs to v6.3.2 (#14952) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.n... de88a12
  • [grid] use a single event listener for the event-bus health check 269a7f6
  • Merge branch 'trunk' into firefox-entensions 87b257d

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
This is already unreachable with `null` using normal means, but this constructor is public-facing so we need the validation.

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
This already throws `ArgumentNullException` because of the `Dictionary.Add` just below

View on GitHub

Load more