Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
A reference to the spec is good. How about then: `This error status is no longer returned by the WebDriver Specification https://www.w3.org/TR/webdriver2/#errors`?
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
What about a message like `WebDriver no longer returns this error status`?
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
That makes complete sense. In this PR, I would like to replace `UnhandledError` with the better `UnknownError`. In some follow-up PR I can try to improve this branch of the response parsing.
RenderMichael pushed 1 commit to unhandled-error RenderMichael/selenium
- remove extra period in XML doc bd62f6f
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I made the obsoletion message `"This result is not returned by W3C specifications"`. Since anyone dealing with this enum is going to be an advanced user, we can be clear with them why this is obsol...
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I took the suggestion you mentioned: ```csharp [Obsolete] UnhandledError = 13, UnknownError = 13, ``` So anyone still using `UnhandledError` is not broken. I went through and obsoleted a...
RenderMichael pushed 1 commit to unhandled-error RenderMichael/selenium
- Add obsoletion to `NoSuchDocument` as well 0914067
RenderMichael pushed 2 commits to unhandled-error RenderMichael/selenium
RenderMichael pushed 4 commits to unhandled-error RenderMichael/selenium
RenderMichael pushed 4 commits to unhandled-error RenderMichael/selenium
- [grid] Distributor listen and handle the NodeRestartedEvent (#14938) Signed-off-by: Viet Nguyen Duc <nguyenducviet44... 8a04527
- [grid] delay the newsessionqueue response (#14764) * [grid] delay the newsessionqueue response * Update variable ... 359ac9a
- [java] Fix FedCM command definition and tests (#14070) Co-authored-by: Puja Jagani <[email protected]> c2d859c
- Merge branch 'trunk' into unhandled-error 1a6e524
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Is this exception reachable? If so, should it be `WebDriverException` instead of invalid operation exception?
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
There are 3 remaining (in-spec) `WebDriverResult` values which do not have custom exceptions (every single other case does, so I assume it's desirable) - [`NoSuchCookie`](https://www.w3.org/TR/w...
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
No changes in this file - only re-ordering to align with spec, for readability
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I took the suggestion of making the new error value an alias for the old one.
RenderMichael pushed 2 commits to unhandled-error RenderMichael/selenium
RenderMichael pushed 4 commits to unhandled-error RenderMichael/selenium
- add `locators.html` file in static web pages (#14905) * add locators.html file for docs * remove `action_page.php... 5cc56b0
- [java] setter for flag JsonInput.readPerformed (#14921) Co-authored-by: Puja Jagani <[email protected]> dbe1004
- [ci] Run format script Signed-off-by: Viet Nguyen Duc <[email protected]> 7854e62
- Merge branch 'trunk' into unhandled-error fddbd4e
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Opened a PR for removing `UnhandledError` https://github.com/SeleniumHQ/selenium/pull/14936 Broken off from this PR because there is still a decision to be made about wrapping in `WebDriverExce...
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Description taken from [spec](https://www.w3.org/TR/webdriver2/#dfn-unknown-error)
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
This code is a best-effort attempt to give users a decent status. Reading through [the spec](https://www.w3.org/TR/webdriver2/#dfn-unknown-error), it looks like `unknown error` is generally used...