Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

RenderMichael

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael opened a pull request on SeleniumHQ/selenium
[dotnet] Remove out-of-spec `UnhandledError` error status
**Thanks for contributing to Selenium!** **A PR well described will help maintainers to quickly review and merge it** Before submitting your PR, please check our [contributing](https://github.c...
RenderMichael created a branch on RenderMichael/selenium

unhandled-error - A browser automation framework and ecosystem.

RenderMichael pushed 1 commit to trunk RenderMichael/selenium
  • [java] use Local.ENGLISH for lower / upper case transformations #14916 cc5ca35

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Looking into it, I see `UnhandledError` maps to the server errors for [`unknown error`] and (https://www.w3.org/TR/webdriver2/#dfn-unknown-error) [`unsupported operation`](https://www.w3.org/TR/web...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
> Thus I think of Response class should be OneOf<Success, ServerSideError>. Sounds good. So we have two options: 1. Allow custom implementations of `ICommandExecutor.ExecuteAsync` to throw `H...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I think `UnhandledError` should be moved to the top of the `WebDriverResult` so it is the `default` value. That should be the correct usage of that value, something like "there is an issue on the ....

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael pushed 15 commits to http-exception RenderMichael/selenium
  • [bazel]: Bump `rules_protobuf` to avoid warning about `maven` namespace (#14891) 7cde7f8
  • [bazel]: Prepare for bump of `rules_closure` (#14890) Future updates to `rules_closure` remove the handy `closure/li... 2cc530d
  • [bazel] Switch to rules_closure 0.12.0 (#14895) 744e7d6
  • [rb] BiDi Network: add_request_handler, remove_request_handler, clear_request_handlers (#14751) * Start the work on ... 89b84ae
  • [dotnet] [bidi] Convert RemoteRefrence to an interface daf7356
  • [dotnet] [bidi] Convert RemoteObjectReference to an interface 19b7b5d
  • [dotnet] [bidi] Fix name of autodetect proxy configuration e6d6e0b
  • [rust] Use file lock to protect concurrent accesses to cache (fix #13511 and #13686) * [rust] Use file lock to prote... 6ce47b2
  • [dotnet] [cdp] Add more internal logs around CDP implementation Related to #14903 cd138fc
  • [java]: Improved span name for `TracedCommandExecutor` (#14902) Co-authored-by: Puja Jagani <[email protected]> 825b040
  • Automate dependencies repins for Renovate PRs (#14709) Co-authored-by: Viet Nguyen Duc <[email protected]> 7ee9d16
  • [dotnet] Correct assertion of struct type in internal tests (#14878) 4f25f67
  • [dotnet] Add nullability annotations to `SessionId` (#14841) c0b45ad
  • [java] use Local.ENGLISH for lower / upper case transformations #14916 cc5ca35
  • Merge branch 'trunk' into http-exception eb40584

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
That may be useful if we want to do “error as value” calculations. The type would gain a new meaning of `OneOf<Success, ErrorResponse, Exception>` My concern with that is, either there is a conn...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a comment on a pull request on SeleniumHQ/selenium
This is a general improvement, but it does pave the way to strongly-typed Reponses, instead of relying on `object? Value`. This may not give any AOT advantages, but it would be a huge improvemen...

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Catching all exceptions would be possible. A couple of questions about that: 1. When the server returns an error response, it’s still some response. In this case, a connection error is not reall...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
It seems like part of the contract of the `ICommandExecutor.ExecuteAsync` method is that it can throw `HttpRequestException`. However, `WebDriver.ExecuteAsync` should not, it should only throw `Web...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a comment on an issue on dotnet/roslyn
Opened PR https://github.com/dotnet/roslyn/pull/76552 for the fix, the regression tests all pass but I'm a little hesitant to make a change I don't 100% understand the consequences of. Hope it's a...

View on GitHub

RenderMichael pushed 1 commit to null-fixer RenderMichael/roslyn
  • Allow null langword fixer at the end of an XML tag f7dabe1

View on GitHub

RenderMichael opened a pull request on dotnet/roslyn
Allow null langword fixer at the end of an XML tag
Fixes #76548 This allows users to more naturally type `null` and follow it up with `Ctrl+.` to immediately convert to `<see langword="null"/>`
RenderMichael created a branch on RenderMichael/roslyn

null-fixer - The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.

RenderMichael created a comment on an issue on dotnet/roslyn
I think I figured out the issue: when inside an XML tag and the cursor is at the end of the inner text, the located token is actually the closing XML tag. I added the following test to the fixer: ...

View on GitHub

RenderMichael pushed 5925 commits to main RenderMichael/roslyn
  • Disable 'use coalesce expression' when statements cross a PP boundary 0cbbeb4
  • Update type inference in a primary constructor base type 1001e8a
  • Fix wrapping issues in simplify conditional d8bda18
  • Filter out certain compiler attributes when extracting an interface 28465d9
  • Update suggestion mode provider to support params collections 2e4bcdc
  • Enable test 2f9b0b9
  • lint a6e747a
  • Support implementing protected members in implement interface 73588ff
  • Lang check 07114ef
  • Do not pass primary constructor parameters explicit when extracting methods 04e15f4
  • Delete dupe loc strings (#76159) f9f45b9
  • Property update return type when updating method. (#76157) Fixes https://github.com/dotnet/roslyn/issues/55975 5213c18
  • Support nit/intptr conversion on c# 11 and up 13df88f
  • Update tests b7f6ae1
  • Catch expected exception when reading info out of a PDB dc496b2
  • Cleanup bc41f30
  • Disable 'use pattern matching' when eliding multiple calls that pass by ref df45e32
  • Fix 9879a92
  • Merge branch 'main' into fix/74327-ctor-params-in-static c799e72
  • Adjust verification and enable skipped tests b350537
  • and 5905 more ...

View on GitHub

RenderMichael created a comment on an issue on dotnet/roslyn
I'm assuming it's a crash or an exception somewhere down the line, because the Suggestions menu loads then abruptly disappears. Whatever the issue happens to be should be trivial to reproduce by ru...

View on GitHub

RenderMichael pushed 1 commit to ini-file-reader RenderMichael/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
```suggestion /// <para>If <paramref name="valueName"/> is <see langword="null"/> or <see cref="string.Empty"/>.</para> ```

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael pushed 1 commit to ini-file-reader RenderMichael/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
```suggestion /// <para>If no section named <paramref name="sectionName"/> exists.</para> ```

View on GitHub

Load more