Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
RenderMichael opened a pull request on SeleniumHQ/selenium
[dotnet] Refactor away private constructor from `Response`
**Thanks for contributing to Selenium!** **A PR well described will help maintainers to quickly review and merge it** Before submitting your PR, please check our [contributing](https://github.c...
RenderMichael created a branch on RenderMichael/selenium
response-ctor - A browser automation framework and ecosystem.
RenderMichael pushed 3 commits to trunk RenderMichael/selenium
RenderMichael created a comment on a pull request on SeleniumHQ/selenium
Well you found a bug related to nullness, so that’s something :) Yes my initial plan was just to quickly sweep through this section and reinforce whatever the code already does (in this case, a...
RenderMichael pushed 2 commits to cookie-jar RenderMichael/selenium
RenderMichael pushed 4 commits to cookie-jar RenderMichael/selenium
RenderMichael created a comment on a pull request on SeleniumHQ/selenium
OK, I removed nullability from the offending method `ICookieJar.DeleteCookieNamed(string)`. That can be addressed in a follow-up which addresses the delete null from Firefox bug.
RenderMichael pushed 1 commit to cookie-jar RenderMichael/selenium
- Remove nullability from `ICookieJar.DeleteCookieNamed(string)` 7c8d30d
RenderMichael created a comment on a pull request on SeleniumHQ/selenium
That’s completely fair. One solution is to obsolete the current method, and make two new methods: `GetCookie` which throws when the cookie doesn’t exist, and a `TryGetCookie` which doesn’t throw. I...
RenderMichael created a comment on a pull request on SeleniumHQ/selenium
I actually use these methods in my test assertions, with methods like “assert cookie with name x does not exist”. The null check makes this easy. That’s my guess about why this was implemented t...
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Actually, the implementation class `CookieJar` explicitly handles the `null` case. Maybe it's an allowed input? 
RenderMichael pushed 1 commit to null-manager RenderMichael/selenium
- Remove changes to `SwitchTo()` c0c0f41
RenderMichael pushed 1 commit to null-manager RenderMichael/selenium
- Remove changes from logs 8782a6c
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
The existing behavior for passing in null is exceptional 
RenderMichael opened a pull request on SeleniumHQ/selenium
[dotnet] Add nullability to Logs API
**Thanks for contributing to Selenium!** **A PR well described will help maintainers to quickly review and merge it** Before submitting your PR, please check our [contributing](https://github.c...
RenderMichael created a branch on RenderMichael/selenium
logs - A browser automation framework and ecosystem.
RenderMichael pushed 1 commit to null-manager RenderMichael/selenium
- remove nullability from `CookieJar` b730723
RenderMichael pushed 32 commits to null-manager RenderMichael/selenium
- Update mirror info (Wed Nov 27 12:08:30 UTC 2024) 2e8816f
- [java]: encapsulate `additionalCommands` with getter method (#14816) * change scope of `additionalCommands` to `prot... 59aa1a0
- [java] Ignoring no shadow root test due to https://issues.chromium.org/issues/375892677 Related to #14631 8594d5e
- [dotnet] Ignoring no shadow root test due to https://issues.chromium.org/issues/375892677 Related to #14631 e71f0db
- [dotnet] Add nullability annotations to `ShadowRoot` (#14812) 4fe2a56
- [dotnet] Fix `WebDriver.AuthenticatorId` to return proper state set by user (#14814) cfaa8c4
- [dotnet] Add future-proofing note on `Base64UrlEncoder` (#14821) 6dc99f5
- [java] SpotBugs exclude `NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE` from the `firefox.AddHasExtensions$1` (#14766) Co-a... a96f6aa
- [java] read complete output of selenium manager #14820 17a2c33
- [py] fix packaging (#14823) Ensure `selenium.webdriver.common.fedcm` gets packaged in. 5c49a66
- Run update_copyright script. No logical changes 5e3d04f
- [bazel] Bump `rules_jvm_external` to 6.6 and use the maven resolver (#14829) By using the maven resolver, we can mak... ff7fa52
- [dotnet] Add nullable reference annotations to `Platform` (#14834) 209e275
- [dotnet] Fix Virtual Authenticator removal, annotate NRT (#14822) b256c5f
- [dotnet] Annotate Nullable Reference Types on `OpenQA.Selenium.Internal` (#14840) 51e7267
- [dotnet] Annotate nullable reference types in internal logging (#14819) 4f07e4a
- [py] Update README command install source distribution from PyPI Follow https://packaging.python.org/en/latest/discu... dd8c914
- [rb] Add tests for the cookie named, and updates type (#14843) * add tests for the cookie named, and updates type ... 901dc6c
- [rb] Update note for return value of Hash (#14845) Update note for return value of Hash ce7448b
- [rust] xz uncompressor for Firefox Linux nightlies (#14832) * [rust] Add xz2 dependency The xz2 crate is already ... 966bed6
- and 12 more ...
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Also lines up with below method which does a null check
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
This is safe because the current behavior of `DeleteCookieNamed(null)` does nothing. Easier to do this than to make parameter values nullable.