Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

RenderMichael

RenderMichael pushed 1 commit to input-device RenderMichael/selenium
  • Do not demand for `PointerMoveInteraction.target` to be not-null e244523

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
> Am I right that this hidden knowledge is private? If yes, we can leave it as is. This is a debacle of the `Actions` vs `ActionsBuilder` class. The `Actions` class exposes higher-level operatio...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Removed the nullability annotation

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael pushed 1 commit to httpCommandExecutor RenderMichael/selenium
  • Remove nullability annotation from `HttpCommandExecutor.CreateHttpClient` 312791e

View on GitHub

RenderMichael created a comment on a pull request on SeleniumHQ/selenium
I'm doing my best to keep each PR completely isolated from the other ones, so they can take as much time as they need to merge. Some points I am more active, other times I will go days without a...

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Once we enable `#nullable` for the full file, we will mark `this.client` as maybe-null. However, after calling this method, we know for sure that `this.client` is not null. So we can do something l...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael opened a pull request on SeleniumHQ/selenium
[dotnet] Annotate nullability on `HttpCommandExecutor` aside from `Response`
**Thanks for contributing to Selenium!** **A PR well described will help maintainers to quickly review and merge it** Before submitting your PR, please check our [contributing](https://github.c...
RenderMichael created a branch on RenderMichael/selenium

httpCommandExecutor - A browser automation framework and ecosystem.

RenderMichael pushed 1 commit to trunk RenderMichael/selenium
  • [dotnet] Add nullability annotations to `Proxy` (#14861) be90e2f

View on GitHub

RenderMichael deleted a branch RenderMichael/selenium

proxy

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Unfortunately without this change, we will hit Argument Null exceptions sometimes. The session ID string can be null something.

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a comment on a pull request on SeleniumHQ/selenium
Fixed, all irrelevant changes are removed.

View on GitHub

RenderMichael pushed 1 commit to session-id RenderMichael/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Fixed

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael pushed 1 commit to proxy RenderMichael/selenium

View on GitHub

RenderMichael created a comment on a pull request on SeleniumHQ/selenium
> where this "opaque" functionality is used across whole code base? Once in the code (the `WebDriver` line that is being changed) and once in tests. Both cases, it is exclusively to conform to ...

View on GitHub

RenderMichael created a comment on a pull request on SeleniumHQ/selenium
Looking through the history, this type used to live in the `Remote` namespace, and it was [introduced in 2011](https://github.com/SeleniumHQ/selenium/commit/713bbdda13ca4699a74db2c26d6ea8d609f953d2...

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
PR is updated to include only nullability improvements.

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael pushed 1 commit to session-id RenderMichael/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
In order to reach this exception, the user would have to do something like this: ```csharp var proxyValues = new Dictionary<string, object?>() { ["noProxy"] = new string?[] { null } }; ...

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
fixed

View on GitHub

RenderMichael created a review on a pull request on SeleniumHQ/selenium

View on GitHub

RenderMichael pushed 1 commit to proxy RenderMichael/selenium

View on GitHub

Load more