Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I understand the concern with avoiding unnecessary changes. The changes we're talking about here are a direct result of nullability improvements. I'll try to avoid unnecessary style changes.
RenderMichael created a comment on an issue on dotnet/roslyn
Confirmed that it's fixed in preview, thanks!
RenderMichael closed an issue on dotnet/roslyn
`ReadOnlySpan<T>` nullability is not covariant
**Version Used**: .NET 9.0.101 **Steps to Reproduce**: ```csharp internal static string CombineWithSlash(ReadOnlySpan<string> pathElements) { return string.Join('/', pathElements); } ``` *...
RenderMichael created a comment on a pull request on SeleniumHQ/selenium
I think this whole class tries to be an opaque wrapper over a string. It already implements `GetHashCode()` and `object.Equals`. The changes here just finish that job. I can remove it if that's pre...
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
People like the `is { }` construction more it looks like https://grep.app/search?q=%3F.ToString%28%29%20is%20%7B
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
> you think it is normal and widely used? It's used when people want to do this kind of thing: https://grep.app/search?q=%3F.ToString%28%29%20is%20string
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
if a type is `string?` then `is string` will just be a null check. We can also do `proxyTypeObj?.ToString() is { } proxyType` if that's more clear.
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I think this part is still good! We don't need to revolutionize the whole process, this class is still useful (and used by users). This PR is small and if we really want to delete it in the future,...
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
I just folded two null checks into one: ```csharp if (proxyTypeObj is not null) { string? proxyType = proxyTypeObj.ToString(); if (proxyType is not null) { ... } ...
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Bit by bit. After `SessionId` is strengthened, after the `Response` PR modernizes the type, we will keep improving each little part.
RenderMichael pushed 6 commits to proxy RenderMichael/selenium
- [ci] Update script pinned_browsers for changes in Edge API product fetch (#14865) Signed-off-by: Viet Nguyen Duc <ng... a3af929
- [py] moved all getters in `fedcm/account.py` into descriptor object. (#14858) 313f7a5
- [dotnet] Migrate NUnit assertions to `Assert.That` syntax (#14853) ae6fe72
- [dotnet] Address warnings with `ActionSequence.inputDevice` and use proper alternative (#14848) 22a6f0b
- [dotnet] Migrate remaining NUnit assertions to `Assert.That` and `Has.Count` (#14870) 40ea8a4
- Merge branch 'trunk' into proxy 10f3317
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
This PR does a bunch of things, but does not include the breaking change I'm referring to. It would first require big changes to `HttpCommandExecutor.CreateResponse`. This PR does not have any b...
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
That's a much bigger discussion 😁 Yes, right now `Response.SessionId` can be null. It will need a greater refactor to be fixed, if it's even possible to *always* populate that field. If we s...
RenderMichael pushed 2 commits to session-id RenderMichael/selenium
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Good point ```suggestion public override string ToString() ```
RenderMichael created a review comment on a pull request on SeleniumHQ/selenium
Done, made sure to avoid nullability issues in `WebDriver` which may have been using this
RenderMichael pushed 1 commit to session-id RenderMichael/selenium
- Add argument null exception XMLDoc 9544bad