Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Pierre-Bartet created a comment on an issue on dask/dask
Yes there are some aggregation then dispatching to be done but it is the case for many algorithms.
Pierre-Bartet created a comment on an issue on dask/dask
Nice, so then what is the limitation preventing a true lazy implementation?
Pierre-Bartet created a comment on an issue on dask/dask
Ok thanks for explanation. Indeed now I understand why I was losing my sanity ^^ Is this non lazy sorting also non parallel (does `dask` squashes the chunks before sorting)?
Pierre-Bartet created a comment on an issue on dask/dask
I still don't get it, using `df.set_index("some_colulmn")` doesn't immediately trigger a computation, so it still look like at least somewhat lazy, yet I can't find a parallel merge sort happening ...
Pierre-Bartet created a comment on an issue on dask/dask
Indeed, so could we do the same thing for `dask` arrays as what is done for `dask` dataframes `set_index`? Or am I missing something (for example `set_index` also squashing the chunk before sorti...
Pierre-Bartet created a comment on an issue on dask/dask
I gave a look and it looks like it's still hard not in itself but because if I understand properly the existing shuffle (such as `set_index`) are still not lazy (which is what stopped me 6 years ag...
Pierre-Bartet created a comment on an issue on dask/dask
Interesting to see that this is still open 6 years later! I still find the solution to silently squash chunks very treacherous. Countless people will be bitten by such an unexpected behavior. As ...
Pierre-Bartet created a comment on a pull request on onnx/onnx
> it still needs to "always contain UTF-8 encoded or 7-bit ASCII text, and cannot be longer than 2^32." according to the protobuf string type definition. Sounds reasonable, and then the checker ...
Pierre-Bartet pushed 1 commit to add_select_k_best_test Pierre-Bartet/sklearn-onnx
- Rely on a public sklearn attribute instead of a private one a4af89e
Pierre-Bartet created a comment on a pull request on onnx/sklearn-onnx
No `tests/test_sklearn_feature_selection_converters.py` test fail when doing that, but other tests fail elsewhere. So from what I understand, the answer to question 2. is "Yes". I guess this is a...
Pierre-Bartet pushed 1 commit to add_select_k_best_test Pierre-Bartet/sklearn-onnx
- Fix formatting 86c54ba
Pierre-Bartet created a comment on a pull request on onnx/sklearn-onnx
@xadupre I fixed the issue (just for `SelectKBest`, not the other selectors), but before I go further I want to be sure I understand properly what was the initial intention of the code I changed. ...
Pierre-Bartet pushed 7 commits to add_select_k_best_test Pierre-Bartet/sklearn-onnx
- Fix conversion for XGBClassifier and XGBRegressor (#1157) Signed-off-by: xadupre <[email protected]> 6652a5c
- update CI to test 1.6.1 (#1158) Signed-off-by: xadupre <[email protected]> d600333
- Investigate issue 1102 (#1103) * Investigate issue 1102 Signed-off-by: Xavier Dupre <[email protected]> * ... 1627bf1
- Investigate issue 1129 (#1131) * add test to investigate Signed-off-by: xadupre <[email protected]> * Add ... e0799d3
- Fix empty column selector (#1159) * Add a test to trigger the bug Signed-off-by: Pierre Bartet <pierre@adlin-scie... 469a18b
- Update test_sklearn_feature_selection_converters.py Signed-off-by: Pierre Bartet <[email protected]> c8196fd
- Fix the problem? Signed-off-by: Pierre Bartet <[email protected]> 6bff77d
Pierre-Bartet pushed 1 commit to add_select_k_best_test Pierre-Bartet/sklearn-onnx
- Fix the problem? f74f80d
Pierre-Bartet created a comment on a pull request on onnx/sklearn-onnx
This is a one liner fix and all the existing and added tests pass so yes!
Pierre-Bartet created a comment on a pull request on onnx/sklearn-onnx
Sorry for not running Black before pushing then ^^
Pierre-Bartet created a comment on a pull request on onnx/sklearn-onnx
Are the workflows run automatically when pushing a new commit or do you have to approve each run each time ?
Pierre-Bartet pushed 3 commits to fix_empty_column_selector Pierre-Bartet/sklearn-onnx
- Add a test to trigger the bug Signed-off-by: Pierre Bartet <[email protected]> abea917
- Fix _parse.py Signed-off-by: Pierre Bartet <[email protected]> 5c18c61
- Fix formatting Signed-off-by: Pierre Bartet <[email protected]> 1dcc815
Pierre-Bartet pushed 1 commit to fix_empty_column_selector Pierre-Bartet/sklearn-onnx
- Fix formatting b6e5459
Pierre-Bartet created a comment on a pull request on onnx/sklearn-onnx
@xadupre this one is ready for review (and I turned the non ready one into a draft).
Pierre-Bartet created a comment on an issue on onnx/sklearn-onnx
Yes they never actually enforced it, and now it has even been removed from the specification (from MUST to SHOULD). Does it mean `sklearn-onnx` can just drop the corresponding check now?
Pierre-Bartet created a comment on an issue on onnx/sklearn-onnx
The `onnx` specification has just been updated to drop the C90 identifier requirement: https://github.com/onnx/onnx/pull/6652.
Pierre-Bartet created a comment on a pull request on onnx/onnx
Nice, does it mean that the names can be any string of bytes, or is it still restricted to some subset such as ascii ?
Pierre-Bartet pushed 6 commits to fix_empty_column_selector Pierre-Bartet/sklearn-onnx
- Fix conversion for XGBClassifier and XGBRegressor (#1157) Signed-off-by: xadupre <[email protected]> 6652a5c
- update CI to test 1.6.1 (#1158) Signed-off-by: xadupre <[email protected]> d600333
- Investigate issue 1102 (#1103) * Investigate issue 1102 Signed-off-by: Xavier Dupre <[email protected]> * ... 1627bf1
- Investigate issue 1129 (#1131) * add test to investigate Signed-off-by: xadupre <[email protected]> * Add ... e0799d3
- Add a test to trigger the bug Signed-off-by: Pierre Bartet <[email protected]> 77310d5
- Fix _parse.py Signed-off-by: Pierre Bartet <[email protected]> f5be77c
Pierre-Bartet pushed 2 commits to fix_empty_column_selector Pierre-Bartet/sklearn-onnx
- Add a test to trigger the bug Signed-off-by: Pierre Bartet <[email protected]> a2578be
- Fix _parse.py Signed-off-by: Pierre Bartet <[email protected]> d3f7d4b
Pierre-Bartet opened a pull request on onnx/sklearn-onnx
Fix empty column selector
Fixes #1155 by skipping transforms with no corresponding columns at all, and add the corresponding test.