Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Bit weird this got inlined
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
There are many test cases missing
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This seems unused
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This function seems to be doing two different things: finding selected values in the DOM, and building query segments.
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Normally there should always be a selected button, right? In other words, this check is to deal with unexpected error states. If not, and we can regularly have the state, then defauling to AND i...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Same as the below comment. Old code was better, and `FacetLabelBuilder` should not have `getTabLabel`
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Our use of `label` here is unfortunate, as it creates confusion with Wikibase labels, which are not the same. `Item` is similarly unfortunate, as it is not about Wikibase items. This would be...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Suggestion: drop `getFacetLabel` from `facetLabelBuilder`
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I think the prior code is better. Services normally cater to one use case. It's weird to have multiple public methods, as `FacetLabelBuilder` now has. The previous property label code works,...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This interface is designed for its existing consumer. Using it and its implementation of `FallbackItemTypeLabelLookup` elsewhere for other use cases (generic Wikibase Item label lookup and Property...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This also has the benefit of storing `null`, making the cache remember cases where there is no type.
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Can be simplified to ```php if ( !array_key_exists( $key, $this->propertyIdToType ) ) { $this->propertyIdToType[$key] = $this->getDataTypeIdForProperty( $propertyId ); } return $thi...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
A type doc here is nice
JeroenDeDauw created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
No lazy loading. All 100 values are in the initial HTML. Presumably the initial HTML should already hide all but the top 5 values.
JeroenDeDauw closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Limit initially shown results in list facets
Show only the top 5 values. Allow viewing additional ones. Ideally we also allow hiding the additional ones again. The backend is already limiting to 100 (in `ElasticValueCounter`) ![Image](http...