Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
JeroenDeDauw opened an issue on ProfessionalWiki/WikibaseFacetedSearch
Make list facet "OR behavior" work
AC: * Can switch between AND and OR when both are enabled * Builds correct query when OR is selected * Updates query when switching from AND to OR or the other way round
JeroenDeDauw opened an issue on ProfessionalWiki/WikibaseFacetedSearch
Limit initially shown results in list facets
Show only the top 5 values. Allow viewing additional ones. Ideally we also allow hiding the additional ones again. The backend is already limiting to 100 (in `ElasticValueCounter`) . Having a `LocalizedTextLookup` seems plausible, especially if we have use for it in multiple places. We still...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Unclear that would be better `itemTypeId vs itemType` and `propertyId vs property` are not equivalent
JeroenDeDauw pushed 4 commits to master ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Index item type refactor
Follow-up to #142
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Though like that we get one call to the `PropertyDataTypeLookup` per value. Not necessarily an issue if the used `PropertyDataTypeLookup` implementation does some caching, but certainly not elegant...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
The above-mentioned logic issue seems to change the interface you need anyway. `FacetLabelBuilder->buildLabel( string $valueCount->value, PropertyId $config->propertyId )` And in `FacetLabelB...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Hmm... `LabelLookup` isn't the best interface... My above suggestion might not be better than the current state after all because `LocalizedTextLookup` provides an interface that makes more sense h...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
My first reaction to injecting `LocalizedTextLookup` into the constructor of this class is that we should use `LabelLookup` instead. `ListFacetHtmlBuilder` does not need to know that localization i...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
There is no need to create entities or persist anything
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This is wrong. There is no guarantee that the value is an item id. The [logic that looks at the type of the property of the facet that I described for the frontend approach is still needed](https:/...
JeroenDeDauw created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
Next step to complete this task: Modify `FallbackItemTypeLabelLookup` added by https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/148
JeroenDeDauw opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Extract ItemTypeLabelLookup
This is preparation that adds structure and tests for https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/91