Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
JeroenDeDauw closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Create Elasticsearch fields
AC: * Add dedicated Elastic field per configured facet * example: `wbfs_P42` Related: * https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/39
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Good candidate for own service Similar code in Semantic Wikibase: https://github.com/ProfessionalWiki/SemanticWikibase/blob/master/src/Translation/DataValueTranslator.php#L26
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I suspect something like this will be nice: ```php private function getStatements(): StatementList { return $this->getStatementsLookup()->getStatements(); } private function getStatem...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Stating the obvious: this logic should be in instantiable class(es).
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
`Facet` does not seem needed in the name
JeroenDeDauw pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Add initial search fields 05a739a
JeroenDeDauw closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add initial search fields
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/49 Creates an Elasticsearch field for each configured facet. Example in Kibana:  {` given we use modern PHP
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
`$name` can be computed closer to where it is used and the details of said computation could go into a dedicated private method.
JeroenDeDauw closed a pull request on SemanticMediaWiki/SemanticMediaWiki
Remove "SMWTestsDatabaseTestCase" unused import
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Updated test configuration by removing a specific database test case import ...
JeroenDeDauw pushed 1 commit to master SemanticMediaWiki/SemanticMediaWiki
- Remove "SMWTestsDatabaseTestCase" unused import (#5902) 7ed2e14
JeroenDeDauw pushed 1 commit to master SemanticMediaWiki/SemanticWatchlist
- Fix README badges f18823a
JeroenDeDauw pushed 1 commit to master SemanticMediaWiki/SemanticWatchlist
- Add CI (#113) * Add CI * Bumps MW requirements to 1.39+. * Requires PHP 7.4+ * Adds CI to run tests * Fixes te... 26a5b68
JeroenDeDauw closed a pull request on SemanticMediaWiki/SemanticWatchlist
Add CI
* Bumps MW requirements to 1.39+. * Requires PHP 7.4+ * Adds CI to run tests * Fixes tests to support MW 1.39 * Adapts to changes done to the naming of files.