Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
JeroenDeDauw pushed 1 commit to ConfigPageTest ProfessionalWiki/WikibaseFacetedSearch
- Add ConfigPageTest 1ac84c7
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
It is common to split code into several classes but only have tests for the higher level one. In such cases it's good to include covers tags for the lower level ones in said test.
JeroenDeDauw created a branch on ProfessionalWiki/WikibaseFacetedSearch
ConfigPageTest - Enhanced searching interface with drilldown for Wikibase
JeroenDeDauw pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Add covers tag fa75f33
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
There is arguably some technical debt here, but it's fully contained, so it does not matter. Two guidelines violated here: * Compute things when you need them, don't put them in place just in c...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I ended up adding the below `getFacetConfigForInstanceType`, which is what made me put the TODO on this function.
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Q100, Q200, P100, P200 are similar. Nice to make values more distinct. Q100 Q200 P1 P2 is less likely to result in confusion and is easier to keep in your short term memory
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
The interfaces form the architectural boundary
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
The interfaces go within Application/, their persistence-mechanism-specific implementations go into Persistence/. (It is possible to have interfaces end up in Persistence/ if they are used by a...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I switched to getters, since for access in our application, after the config has been figured out, these values are no longer nullable.
JeroenDeDauw created a branch on ProfessionalWiki/WikibaseFacetedSearch
tconfig - Enhanced searching interface with drilldown for Wikibase
JeroenDeDauw pushed 1 commit to master SemanticMediaWiki/SemanticMediaWiki
- PHPUnitCompat: Replace PHPUnit_Framework_TestCase with \PHPUnit\Framework\TestCase (#5853) * PHPUnitCompat: Replace ... 5735c48
JeroenDeDauw closed a pull request on SemanticMediaWiki/SemanticMediaWiki
PHPUnitCompat: Replace PHPUnit_Framework_TestCase with \PHPUnit\Framework\TestCase
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Updated PHPUnit compatibility to align with the latest namespace structure,...
JeroenDeDauw created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
@malberts what is the state of this? I know there are unknowns around ranges, but the most common filters we could already do, unblocking some dependent tasks.
JeroenDeDauw opened an issue on ProfessionalWiki/WikibaseFacetedSearch
Show instance type choosing facet when there is no filter on the type yet
Somewhat depends on * https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/31
JeroenDeDauw pushed 1 commit to master SemanticMediaWiki/SemanticMediaWiki
- Replace usage of 'PHPUnit_Framework_MockObject_MockObject' (#5856) * Replace 'PHPUnit_Framework_MockObject_MockObjec... 8d31b11
JeroenDeDauw closed a pull request on SemanticMediaWiki/SemanticMediaWiki
Replace usage of 'PHPUnit_Framework_MockObject_MockObject'
JeroenDeDauw pushed 1 commit to master SemanticMediaWiki/SemanticMediaWiki
- Replace ::prepareSave with ::validateSave (#5851) * Replace ::prepareSave with ::validateSave This fixes newer MW... f9de6d0
JeroenDeDauw closed an issue on SemanticMediaWiki/SemanticMediaWiki
SMW\MediaWiki\Content\SchemaContent overrides prepareSave which was deprecated
From MW 1.39 it outputs > Deprecated: SMW\MediaWiki\Content\SchemaContent overrides prepareSave which was deprecated in MediaWiki 1.38. [Called from JsonContentHandler::validateSave in /var/www/htm...
JeroenDeDauw closed a pull request on SemanticMediaWiki/SemanticMediaWiki
Replace ::prepareSave with ::validateSave
This fixes newer MW versions and this is safe with MW 1.39. This is deprecated in 1.39 (and removed in a newer MW version) in prepareSave and replaced with validateSave so this should be safe. ...
JeroenDeDauw pushed 1 commit to master SemanticMediaWiki/SemanticMediaWiki
- QueryPage: Fix "contains 1 abstract method" (#5849) * QueryPage: Fix "contains 1 abstract method" In MW 1.43, get... 5fb4b0b