Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
Seems plausible. Did you run it multiple times to see if the flakiness was reduced?
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
```suggestion brandParamManagers.set(brand, pm); ```
Chris-Hibbert created a comment on an issue on Agoric/agoric-sdk
I tried to create a PR (#10738) to address this, but the fixes cascaded without end. Most of the code that ended up out of compliance was in tests, where failure would be detected appropriately. Bu...
Chris-Hibbert pushed 1 commit to main Agoric/documentation
- Update send-anywhere.md (#1261) * Update send-anywhere.md Various discrepancies have crept in between the docs an... 42501e2
Chris-Hibbert closed a pull request on Agoric/documentation
Update send-anywhere.md
Various discrepancies have crept in between the docs and the code. This updates the doc to match the code in agoric-sdk.
Chris-Hibbert pushed 2 commits to Chris-Hibbert-patch-2 Agoric/documentation
Chris-Hibbert created a review comment on a pull request on Agoric/documentation
Lint insistes on `no-trailing-comma`, which is incorrect for our JavaScript style. Is it worth finding and fixing this?
Chris-Hibbert pushed 1 commit to Chris-Hibbert-patch-2 Agoric/documentation
- chore: make lint happy 9155468
Chris-Hibbert opened a pull request on Agoric/documentation
Update send-anywhere.md
Various discrepancies have crept in between the docs and the code. This updates the doc to match the code in agoric-sdk.
Chris-Hibbert pushed 1 commit to main Agoric/documentation
- Update key-concepts.md `OrchestrationAccountI` link leads to a blank page is `OrchestrationAccountCommon` the intend... 30637d4
Chris-Hibbert closed a pull request on Agoric/documentation
Update key-concepts.md
`OrchestrationAccountI` link leads to a blank page. Is `OrchestrationAccountCommon` the intended destination?
Chris-Hibbert opened a pull request on Agoric/documentation
Update key-concepts.md
`OrchestrationAccountI` link leads to a blank page. Is `OrchestrationAccountCommon` the intended destination?
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
I find it hard to compare these values visually with the previous and following values. What I've done in the past is use a variable to hold the mutating value, so the comparison always looks the s...
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
I made a suggestion that is totally optional.
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
I made a suggestion that is totally optional.
Chris-Hibbert pushed 1 commit to 10760-upgrade-board-U18 Agoric/agoric-sdk
- chore: remove vestiges from p:upgrade-19 5b402ab
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
please add a comment here that the success will be checked in the test by reading from vstorage.
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
This will break if it doesn't find a usdcMint. We should add an assertion so it'll fail deliberately if there are testnets where it's not found?
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
Oh, right. You're getting the contractKit, which uniquely has that name. the governor adminFacet there is the one we want. Your code is correct and I was thinking of the something else.