Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Chris-Hibbert created a comment on a pull request on Agoric/agoric-sdk
> is this approach acceptable It's fine to include these checks in a separate PR.
Chris-Hibbert pushed 2 commits to 10669-saveInstances Agoric/agoric-sdk
Chris-Hibbert created a comment on an issue on Agoric/agoric-sdk
ask @samsiegart if significant parts of the UIs depend on agoricNames. If so, then we can check that agoricNames is working by exercising the UIs.
Chris-Hibbert created a comment on an issue on Agoric/agoric-sdk
As mentioned in #10649, and #10650, please add some details about what to look for when we get to MainNet.
Chris-Hibbert created a comment on an issue on Agoric/agoric-sdk
I like the extra column added in #10650. As I said there, we should add some details about what to verify when the changes get to mainNet. I expect the latter to often just be "check for the fol...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
The most natural form is generic creation of a Map in promiseSpace, but this doesn't leave a place to document the usage of retiredContractInstances. Would you rather have a shared function called ...
Chris-Hibbert pushed 1 commit to 10669-saveInstances Agoric/agoric-sdk
- refactor: extract a method to save the mapStore idempotently f4c67ec
Chris-Hibbert pushed 1 commit to 10669-saveInstances Agoric/agoric-sdk
- chore: lint fixes, and a rename 5f1fc01
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
yes, definitelly. I don't know how that happened. The latter is not even a writer.
Chris-Hibbert pushed 1 commit to 10669-saveInstances Agoric/agoric-sdk
- fixup! refactor: better approach to creating Map and naming saved instances 9eecb43
Chris-Hibbert created a comment on an issue on Agoric/agoric-sdk
I like this format, with the *verify* column, and an indication of what log message to look for. We'd also like to see an indication of what to look for on MainNet. Since we'll have passed mult...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
> "The others will be ignored" might be reliable, but it relies upon non-obvious behavior of the promise-space resolve, which makes it less legible and an ongoing source of questions ("why read th...
Chris-Hibbert pushed 1 commit to 10669-saveInstances Agoric/agoric-sdk
- refactor: better approach to creating Map and naming saved instances 4cc3692
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
@dckc reminded me of the standard pattern for this. Each intended writer creates a MapStore and attempts to save it as `retiredContractInstances`. One of them will win, the others will be ignored. ...
Chris-Hibbert created a comment on a pull request on Agoric/agoric-sdk
> My first reaction is that the explicit naming per "upgrade action" feels error prone. Is there a reason we cannot make this retired instance collection a SetStore and just push into it? Maybe hav...
Chris-Hibbert pushed 1 commit to 10669-saveInstances Agoric/agoric-sdk
- test: repair test to not expect mainNet assets b2d8441
Chris-Hibbert pushed 2 commits to 10669-saveInstances Agoric/agoric-sdk
Chris-Hibbert pushed 2 commits to 10669-saveInstances Agoric/agoric-sdk
Chris-Hibbert closed an issue on Agoric/agoric-sdk
feeDistributor vat is not ugpradable
While looking at https://github.com/Agoric/agoric-sdk/pull/8499#issuecomment-1842457715 . and thinking about how v28-feeDistributor would react under upgrade, we noticed that v28-feeDistributor is ...
Chris-Hibbert opened a pull request on Agoric/agoric-sdk
Record instances that will be replaced so we can manage them
closes: #10669 ## Description Record instances of contracts that will be replaced so we can find them later and be able to manage them. ### Security Considerations We've lost the handle...
Chris-Hibbert created a branch on Agoric/agoric-sdk
10669-saveInstances - monorepo for the Agoric Javascript smart contract platform
Chris-Hibbert opened an issue on Agoric/agoric-sdk
Save some facets to enable admin of replaced contracts and vats
## What is the Problem Being Solved? When we add a new auction or priceFeed, the `adminFacet`s saved in bootstrap space are overwritten by the newer contract. The old contractKit remains, since ...