Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Chris-Hibbert created a comment on a pull request on Agoric/agoric-sdk
What can we add to the a3p test to show that the parameter change is effective? Ideally something that fails when we don't set `governedParamOverrides`, and succeeds with the code as it is now. It ...
Chris-Hibbert opened a pull request on Agoric/agoric-sdk
Don't reschedule vault's priceNotifier if one exists
refs: #10660 ## Description in testing upgrade 18 candidates, we realized that vaultManager was subject to the same error as auctions fixed in #10615. ### Security Considerations No Sec...
Chris-Hibbert pushed 1 commit to 10660-vaultNotifiers Agoric/agoric-sdk
- refactor: Don't reschedule vault's priceNotifier if one exists a74161c
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
Then it looks less unorthodox than it used to. Maybe the comment isn't necessary?
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
> Please correct me if I am wrong, but to reach this helper, we need to use the handleParamGovernance. One of the main goals of this PR is to replace the use of handleParamGovernance with makePara...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
Can we verify that the method is present without calling it? try `__getMethodNames__()`.
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
The purpose of #10410 is to upgrade the mintHolder vats on mainNet. This PR seems to focus on testing. Will it include adding invocations to `upgrade.go`? This PR also only upgrades mintHolders ...
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
The purpose of #10410 is to upgrade the mintHolder vats on mainNet. This PR seems to focus on testing. Will it include adding invocations to `upgrade.go`? This PR also only upgrades mintHolders ...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
There's helper that can replace the whole creatorFacet. ``` const creatorFacet = makeDurableGovernorFacet(baggage, () => provisionPoolKit.machine); ```
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
Why is it okay to drop this test?
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
I don't have a problem with this.
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
I did mean `installation`, but you're right, that's not available. I was happy with that because one `installation` is shared across many instances. The instances aren't helpful for this. The v...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
That seems like a lot of extra work to go through. The `await null` is unnecessary. I think this is equivalent to the following. Did I miss something? ```suggestion const params = await E(ppPub...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
These aren't needed as long as no one is calling `voteOnApiInvocation()`. (no one is.)
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
looks good. two minor cleanups
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
looks good. two minor cleanups
Chris-Hibbert created a comment on a pull request on Agoric/agoric-sdk
> Oh actually I’ve got nothing to add (other than fixing the CI of course) I'll wait till CI is passing to do a thorough review. > assuming you’ve read the parts under Testing Considerations a...
Chris-Hibbert created a comment on a pull request on Agoric/agoric-sdk
> do you agree with the test design currently implemented? Yep, seems fine.
Chris-Hibbert pushed 1 commit to main Agoric/documentation
- Durable contracts (#1255) * docs: durable contract details collected in one place * docs: more detail and more cr... 537427b