Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Chris-Hibbert closed an issue on Agoric/documentation
describe upgrade contract meta info
Contracts originally were required to return a `start` function. At some point, we changed the name to `prepare` to signal upgradeability. [#8045](https://github.com/Agoric/agoric-sdk/pull/8045) ch...
Chris-Hibbert closed a pull request on Agoric/documentation
Durable contracts
closes: #1126 ## Description Collect the details on creating durable contracts in one place. Update to cover use of `meta` with `start` and stop recommending `prepare` for this. Also prov...
Chris-Hibbert pushed 1 commit to durableContracts Agoric/documentation
- chore: better format for glossary link 0335f86
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
I think everyone would be satisfied if we first filter for the installation, and then look for the exact name. At the moment, there's only one installation for mintHolder, so we can just get the un...
Chris-Hibbert created a comment on a pull request on Agoric/agoric-sdk
> Based on the list above, it makes more sense to extend the mintHolder tests coverage by executing a swap via PSM. @Chris-Hibbert Should we test all the assets displayed on the PSM list or only t...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
> in order to open a vault there needs to be a valid instance object in published.agoricNames.instance for VaultFactory. sounds good. > The fact that we are able to append and observe new ch...
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
Your approach seems like it covers the bases. I think you're not done yet, so I didn't do a complete review. Let me know if/when it's ready.
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
Your approach seems like it covers the bases. I think you're not done yet, so I didn't do a complete review. Let me know if/when it's ready.
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
s/insert/assert/ sorry for the confusing typo.
Chris-Hibbert pushed 1 commit to durableContracts Agoric/documentation
- chore: cleanup with yarn format c80699b
Chris-Hibbert created a review comment on a pull request on Agoric/documentation
done. I like "record" here.
Chris-Hibbert created a review comment on a pull request on Agoric/documentation
I don't like "levels of access". "kit of facets" (with links) works for me.
Chris-Hibbert created a review comment on a pull request on Agoric/documentation
I don't feel up to writing that glossary entry. I'll leave that to your hypothetical future PR.
Chris-Hibbert pushed 1 commit to durableContracts Agoric/documentation
- chore: clean up links and improve wording Thanks, Dan! 8368811
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
All of the bids are in IST, so there's no chance of that. With Vaults, we explicitly intended that we might want to have multiple vaultManagers for a given currency that could have different min...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
On line 469, we add the brand to the set, and on line 472, we attempt to create the notifier. On line 477, we await the notifier. If the creation promise fails, we end up here, and want to ensure ...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
Sorry, we lost the race with the merge. Please let me know if you think it's worth a new PR to add the comment. I'm happy to do it if you ask.
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
lots of vats have `ATOM` in their names. Let's find a better way to uniquely identify the mintHolder vat. The name also has 'mintHolder' in it, so that's not unique yet. On MainNet, there are va...