Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
```suggestion insert as the first argument a "powers" object that includes functions such as ```
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
Thanks for the expansion and clarification.
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
Thanks for the expansion and clarification.
Chris-Hibbert created a comment on an issue on Agoric/agoric-sdk
> Is this test environment appropriate for reproducing the issue, or would you prefer an alternative setup? Yep, but it needs `force-integration` before it'll run the docker tests. I added the l...
Chris-Hibbert created a comment on an issue on Agoric/agoric-sdk
> During the acceptance test execution This would be easier to review with a PR and CI test output. Would you provide a link?
Chris-Hibbert created a comment on an issue on Agoric/agoric-sdk
The advice I got was that this upgrade should be tested in KREAd's repo rather than `agoric-sdk/a3p-integration`. The way to proceed would be to * create a PR against `https://github.com/Kryha...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
'adhered' is the wrong word, but I'm not sure what you were trying to say. Maybe 'respected' would work? (or verified?) (and later, too)
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
```suggestion /// ////////// Make sure an election held by a given committee ///////////// /// ////////// (see @agoric/governance) turned out as expected ///////////// ```
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
[see the wiki](https://github.com/Agoric/agoric-sdk/wiki/Coding-Style#code-comments). As an explicit statement about something to change shortly, this makes more sense as a TODO than as tech debt....
Chris-Hibbert created a review on a pull request on Agoric/agoric-sdk
formatting cleanups, but otherwise ready to go.
Chris-Hibbert created a comment on a pull request on Agoric/agoric-sdk
> https://github.com/Agoric/agoric-sdk/issues/10425 tracks this now. From your comment I understand the path for this PR to land; > * Close 10425 > * wait the plan for upgrading `vat-bootstrap`...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
I don't think there is any difference between the above and this shorter version. ```suggestion const makeQueryWalletCurrent = follow => (/** @type {string} */ addr) => follow('-lF', `:publish...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
Please drop the blank line.
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
```suggestion * @param {string} addr * @param {string} offerId * @param {{ follow: () => object, log: typeof console.log, setTimeout: typeof global.setTimeout}} io * @param {WaitUntilOption...
Chris-Hibbert created a comment on an issue on Agoric/agoric-sdk
> To mitigate this, I utilized the [resolution field](https://github.com/Jorge-Lopes/KREAd/blob/jorge/10392-contract-upgrade/agoric/package.json#L58-L84) to address both dependency and size issues....
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
Is this log message intended to be once for the entire loop, or once per step? It's either in the wrong place, or not clear enough. How about ```suggestion for await (const i of asyncGenerator...
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
If opening each new vault increases the allocation, why do we need to repeat that multiple times? Isn't one time sufficient?
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
```suggestion // Wait for a round to give the new feeDistributor time to clear out outstanding fees, if any. ```
Chris-Hibbert created a comment on an issue on Agoric/agoric-sdk
> Do we already have tests of that? We do not. But now that we've replace auctions and upgraded vaults, I'd expect such tests to pass. I'll work on adding them.
Chris-Hibbert created a review comment on a pull request on Agoric/agoric-sdk
Oh! good point. I'll have to figure out how to pass the bundle through without installing a contract. We use `publishRef(install())` in the Zoe proposals. I don't know why that's okay.