Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ChiefStief pushed 1 commit to feat/militar-affiliation InspiringApps/JCC-CompactConnect
- start modal functioning ee1cff3
ChiefStief pushed 1 commit to feat/militar-affiliation InspiringApps/JCC-CompactConnect
- some military status styling 3872d12
ChiefStief created a branch on InspiringApps/JCC-CompactConnect
feat/militar-affiliation - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
ChiefStief created a comment on a pull request on csg-org/CompactConnect
We may want click-off / press off to toggle off the mobile side-bar
ChiefStief pushed 1 commit to feat/auth-tweaks InspiringApps/JCC-CompactConnect
- Update webroot/README.md Co-authored-by: Joshua Kravitz <[email protected]> 9464ec5
ChiefStief created a comment on a pull request on csg-org/CompactConnect
@jlkravitz I added to the existing webroot readme and addressed all your comments, so the PR should be ready for a full re-review.
ChiefStief pushed 1 commit to feat/auth-tweaks InspiringApps/JCC-CompactConnect
- readme tweak c5c29e1
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Yes that makes that line not count in the code coverage tester we are using.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
I think this comment was erroneously copy pasted
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
`tokens.staff.AUTH_TYPE` and `tokens.licensee.AUTH_TYPE` both evaluate to the constant `auth_type`. This is a bit obfuscated with the current set up. Would the fix mentioned above "It might also...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
I could do that get once, save it to a variable and then refer to that variable. I could add a comment too explaining that they are the same value. It might also make more sense to move the auth...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Ok, Ill create a readme documenting the nuances of cognito, how our two user pool set up meshes with those nuances and explaining our mitigation efforts.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Actually yes, the way `auth_storage` is evaluated `tokens.staff.AUTH_TYPE` and `tokens.licensee.AUTH_TYPE` are actually stored in exactly the same place as each other in session / local storage. ...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Logged out from the perspective of cognito, not just locally. Local logout would be deleting the tokens. Remote logout would be making the tokens invalid / revoking them + removing http only cookies.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
We retain the access token from both user pools to maintain an indicator that we are still logged in to that user pool remotely. We need this indicator so that the app knows to remotely log the use...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
In the `logout_url` query param we specify where we want to be redirected to after visiting the hosted logout page. But, the `logout_url` we put there must be one of the allowed `logout_urls` liste...