Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
I can get rid of the if block with the changes, but getting rid of the casting causes alot of other issues.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
No, I think I accidentally added a prop here deleted it and was cleaning up after myself. Later, looking at it I didn't feel like reverting the change was necessary as not having the trailing comma...
ChiefStief pushed 1 commit to feat/upload-license-number InspiringApps/JCC-CompactConnect
- consolidate d3e458f
ChiefStief pushed 1 commit to feat/upload-license-number InspiringApps/JCC-CompactConnect
- update tests fbdf838
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
isLoadingOne triggers the loading overlay, isLoading does not. When the License Search page is loading the overlay doesn't pop up, the list itself has a loading spinner. I didn't want to affect ...
ChiefStief pushed 1 commit to feat/upload-license-number InspiringApps/JCC-CompactConnect
- work edc8a5e
ChiefStief opened a draft pull request on csg-org/CompactConnect
license number start
### Requirements List - ### Description List - ### Testing List - `yarn test:unit:all` should run without errors or warnings - `yarn serve` should run without errors or warnings - `yarn ...
ChiefStief pushed 1 commit to feat/license-detail-page InspiringApps/JCC-CompactConnect
- clean up 359675b
ChiefStief pushed 1 commit to feat/license-detail-page InspiringApps/JCC-CompactConnect
- finish up 48e22fe
ChiefStief pushed 1 commit to feat/license-detail-page InspiringApps/JCC-CompactConnect
- clean up 46e47fb
ChiefStief pushed 1 commit to feat/license-detail-page InspiringApps/JCC-CompactConnect
- fix test coverage 6db2c9e
ChiefStief pushed 1 commit to feat/license-detail-page InspiringApps/JCC-CompactConnect
- almost totally done c055d1d
ChiefStief created a branch on InspiringApps/JCC-CompactConnect
feat/upload-license-number - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
ChiefStief pushed 4 commits to feat/license-detail-page InspiringApps/JCC-CompactConnect
ChiefStief pushed 1 commit to feat/license-detail-page InspiringApps/JCC-CompactConnect
- much of styling and layout 3f63cad
ChiefStief pushed 1 commit to feat/license-detail-page InspiringApps/JCC-CompactConnect
- work 68712f3
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
@jlkravitz Sorry I was just confirming why we do this. This is something we do across the codebase. This is just a sanity thing so that we can cleanly define what the properties are going to be ...
ChiefStief created a branch on InspiringApps/JCC-CompactConnect
feat/license-detail-page - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
ChiefStief pushed 1 commit to feat/militar-affiliation InspiringApps/JCC-CompactConnect
- pr fixes c2cec5b
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Casting is needed here to avoid the error: `Property 'length' does not exist on type 'never'.` TS has an annoying well documented behavior initially discussed here: https://github.com/microsoft/...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
It turns out casting is not required on this line given other changes. Why it was used initially will be explained in the comment below explaining why that line does need casting.
ChiefStief pushed 1 commit to feat/militar-affiliation InspiringApps/JCC-CompactConnect
- file name change 832a294
ChiefStief pushed 1 commit to feat/militar-affiliation InspiringApps/JCC-CompactConnect
- pr fixes eb430fb
ChiefStief pushed 1 commit to feat/militar-affiliation InspiringApps/JCC-CompactConnect
- fix validation message 4217dda