Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ChiefStief pushed 1 commit to feat/privilege-selection-tweaks InspiringApps/JCC-CompactConnect
- finish fixes 29bedd7
ChiefStief pushed 1 commit to feat/privilege-selection-tweaks InspiringApps/JCC-CompactConnect
- work b7e699e
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Actually, back to the actual code block we are talking about: that code doesn't seem to work because before normalization the abbrev is not accessible so we cant do: `const model = new State({ abbr...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
I guess we do this: https://stackoverflow.com/questions/75677237/silence-typescript-error-property-does-not-exist-on-type-never
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
This single ts bug has been a thorn in my side many times, I would like to maybe add add a global ignore or rule, I have refactored a fair amount to avoid it. How do you feel about that?
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
So this is another example of the ts never bug: <img width="2560" alt="Screenshot 2024-11-20 at 5 00 11 PM (2)" src="https://github.com/user-attachments/assets/7294afcb-217d-4a7f-88a1-13d40576441...
ChiefStief created a comment on a pull request on csg-org/CompactConnect
Heads up that this is also in the cloudfront-csp lambda and owasp-zap authenticator lambda
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Why is this not accompanied by a resolution in the package.json file?
ChiefStief created a review on a pull request on csg-org/CompactConnect
Looks good. I think I would expect tags to be individual for each search term and each handle toggling off individually / not exiting the search screen when done. If we are doing it this way I'm no...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
It looks like that is a function of having all the terms listed here on separate lines, the white space is bleeding in. I might make a searchText computed concatenating all these.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
I cant tell immediately why but there are spaces being added before the commas between term
ChiefStief created a review on a pull request on csg-org/CompactConnect
Looks good. I think I would expect tags to be individual for each search term and each handle toggling off individually / not exiting the search screen when done. If we are doing it this way I'm no...
ChiefStief created a review on a pull request on csg-org/CompactConnect
Looks good. I think I would expect tags to be individual for each search term and each handle toggling off individually / not exiting the search screen when done. If we are doing it this way I'm no...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Oh got it, that's better than what I did!
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
When I've researched similar issues before, they actually turned out to be ts bugs, I think. The new one that I keep running into is the `'Property does not exist on type 'never''` when we have ...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
And in `SelectPrivileges.ts` I am instantiating the `FormInput` with a boolean value, so it should never get set with string. Also based on the FormInput model, it shouldn't be an issue to set the ...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
<img width="2560" alt="Screenshot 2024-11-20 at 11 49 41 AM (2)" src="https://github.com/user-attachments/assets/a6eee539-86ab-4de5-ac7b-043f7af621f8">
ChiefStief pushed 1 commit to feat/privilege-selection-tweaks InspiringApps/JCC-CompactConnect
- fix build warnings 0277638