Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

y-scope/clp-ffi-js

kirkrodrigues created a comment on an issue on y-scope/clp-ffi-js
> @kirkrodrigues / @davemarco > > Any objection if we [`npm unpublish`](https://docs.npmjs.com/cli/v9/commands/npm-unpublish) 0.3.1 and 0.3.2 (see #48) on the npm registry? No, go for it.

View on GitHub

junhaoliao created a comment on an issue on y-scope/clp-ffi-js
@kirkrodrigues / @davemarco Any objection if we [`npm unpublish`](https://docs.npmjs.com/cli/v9/commands/npm-unpublish) 0.3.1 and 0.3.2 (see #48) on the npm registry?

View on GitHub

junhaoliao closed an issue on y-scope/clp-ffi-js
Version 0.3.1 was released with an older version of the artifacts.
### Bug Version 0.3.1 released at https://www.npmjs.com/package/clp-ffi-js contained an older version of the artifacts because @junhaoliao made the release without rebuilding, though he did used t...
junhaoliao created a comment on an issue on y-scope/clp-ffi-js
A newer version has been released at https://github.com/y-scope/clp-ffi-js/releases/tag/v0.3.3 / https://www.npmjs.com/package/clp-ffi-js/v/0.3.3

View on GitHub

junhaoliao published a release on y-scope/clp-ffi-js
v0.3.3
## What's Changed * Add `LogEventWithFilterData` template class to extend log event classes with processed fields for filtering. by @davemarco in https://github.com/y-scope/clp-ffi-js/pull/32 * U...
junhaoliao created a tag on y-scope/clp-ffi-js

v0.3.3

junhaoliao pushed 1 commit to main y-scope/clp-ffi-js
  • chore: Upgrade version for 0.3.3 release. (#50) cda40a5

View on GitHub

junhaoliao closed a pull request on y-scope/clp-ffi-js
chore: Upgrade version for 0.3.3 release.
<!-- Set the PR title to a meaningful commit message that: - follows the Conventional Commits specification (https://www.conventionalcommits.org). - is in imperative form. Example: fix: Don't ...
kirkrodrigues created a review on a pull request on y-scope/clp-ffi-js

View on GitHub

junhaoliao opened a pull request on y-scope/clp-ffi-js
chore: Upgrade version for 0.3.3 release.
<!-- Set the PR title to a meaningful commit message that: - follows the Conventional Commits specification (https://www.conventionalcommits.org). - is in imperative form. Example: fix: Don't ...
junhaoliao closed an issue on y-scope/clp-ffi-js
Pre-release 0.3.2 was released without any build artifacts.
### Bug ![image](https://media1.giphy.com/media/v1.Y2lkPTc5MGI3NjExajE5YTV5dGlkMGQ4YjlsMXE0em5tNms0aDVweGVnbzIxeWV0aDB3NiZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/whQCarjn5Jv1Ktq2HH/giphy.webp) ...
junhaoliao pushed 1 commit to main y-scope/clp-ffi-js
  • ci(publish-to-npm): Download and extract build as single artifact at the correct path (fixes #48). (#49) b3231bf

View on GitHub

junhaoliao closed a pull request on y-scope/clp-ffi-js
ci(publish-to-npm): Download and extract build as single artifact at the correct path (fixes #48).
Related: #48 <!-- Set the PR title to a meaningful commit message that: - follows the Conventional Commits specification (https://www.conventionalcommits.org). - is in imperative form. Exampl...
kirkrodrigues created a review on a pull request on y-scope/clp-ffi-js

View on GitHub

coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>๐Ÿงน Nitpick comments (1)</summary><blockquote> <details> <summary>.github/workflows/publish-to-npm.yml (1)</summary><blockquote> `40-42`: **Con...

View on GitHub

kirkrodrigues created a review on a pull request on y-scope/clp-ffi-js
One optional comment otherwise lgtm. For the PR title, how about: ``` ci(publish-to-npm): Download and extract build as single artifact at the correct path (fixes #48). ```

View on GitHub

kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Yep

View on GitHub

kirkrodrigues created a review on a pull request on y-scope/clp-ffi-js

View on GitHub

junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
if you mean where a developer downloads the artifacts from the job's Summary page, sure

View on GitHub

junhaoliao created a review on a pull request on y-scope/clp-ffi-js

View on GitHub

kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
This is optional, but do you want to call it something more readable like `clp-ffi-js` or `clp-ffi-js-dist` so that it's obvious when downloaded?

View on GitHub

kirkrodrigues created a review on a pull request on y-scope/clp-ffi-js
One optional comment otherwise lgtm. For the PR title, how about: ``` ci(publish-to-npm): Download and extract build as single artifact at the correct path (fixes #48). ```

View on GitHub

kirkrodrigues created a review on a pull request on y-scope/clp-ffi-js
One optional comment otherwise lgtm. For the PR title, how about: ``` ci(publish-to-npm): Download and extract build as single artifact at the correct path (fixes #48). ```

View on GitHub

junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
Can we pass in the vector directly? e.g. `LogEvents<LogEvent> const& log_events`

View on GitHub

junhaoliao created a review on a pull request on y-scope/clp-ffi-js

View on GitHub

junhaoliao created a comment on a pull request on y-scope/clp-ffi-js
Alternatively, this config would also work though it is less straight forward: ``` - name: "Upload build artifacts" uses: "actions/upload-artifact@v4" with: # H...

View on GitHub

coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>๐Ÿงน Nitpick comments (1)</summary><blockquote> <details> <summary>.github/workflows/publish-to-npm.yml (1)</summary><blockquote> `37-39`: **Con...

View on GitHub

coderabbitai[bot] created a comment on a pull request on y-scope/clp-ffi-js
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: skip review by coderabbit.ai --> > [!IMPORTANT] > ## Review skipped > > Draft detect...

View on GitHub

junhaoliao created a comment on an issue on y-scope/clp-ffi-js
As shown in debug job https://github.com/junhaoliao/clp-ffi-js/actions/runs/12538611685/job/34963975907 the artifacts are stored in `artifact` directory.

View on GitHub

junhaoliao opened an issue on y-scope/clp-ffi-js
Pre-release 0.3.2 was released without any build artifacts.
### Bug ![image](https://media1.giphy.com/media/v1.Y2lkPTc5MGI3NjExajE5YTV5dGlkMGQ4YjlsMXE0em5tNms0aDVweGVnbzIxeWV0aDB3NiZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/whQCarjn5Jv1Ktq2HH/giphy.webp) ...
Load more