Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Seems like it. Not sure how that happened.
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
duplicated with the previous comment?
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
> * When decoding the file, keep track of whether the timestamp of two consecutive log events are out of order "keep track of" means we are basically iterating the log events during the decode rig...
kirkrodrigues pushed 1 commit to main y-scope/clp-ffi-js
- chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`. (#55) b4a6791
kirkrodrigues closed a pull request on y-scope/clp-ffi-js
chore: Update GitHub pull-request template to the latest from `y-scope/public-repo-template`.
<!-- markdownlint-disable MD012 --> <!-- Set the PR title to a meaningful commit message that: * is in imperative form. * follows the Conventional Commits specification (https://www.convent...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Since the case with out of order timestamps is rare (as far as we know), we could maybe do something like: - When decoding the file, keep track of whether the timestamp of two consecutive log ev...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Right, idx vs num is a good point. I think I still prefer *not* including `idx` for a few reasons: - `find_nearest_log_event_idx` makes it sound like we're looking for an index that's nearest to...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Oh, isn't `FilteredLogEventIdx` also [defined](https://github.com/y-scope/yscope-log-viewer/blob/main/src/typings/decoders.ts#L36) in the Log Viewer? It's true that the name in clp-ffi-js doesn't i...
Henry8192 created a comment on an issue on y-scope/clp-ffi-js
@junhaoliao lmk when I can fix this issue.
Henry8192 opened an issue on y-scope/clp-ffi-js
Show Boost fetch status during compilation.
### Request Currently, Boost's fetching status is not shown in detail (with a single message of `-- Fetching Boost.` This makes users "guarded" by the GFW hard to determine whether their internet...
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
_:bulb: Codebase verification_ **Timestamp Ordering Not Verified** - The function in `StreamReader.hpp` employs `std::upper_bound` with a lambda that compares timestamps, which only works correct...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summar...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summar...
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
@kirkrodrigues changed to `find_nearest_log_event_idx_by_timestamp`. I prefer to keep the idx to remind users that we are returning index rather than num (starting from 1). Comment if you disagree.
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
I personally even prefer making the change here, as it is just a internal type name change and won't affect any front end code.
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
@junhaoliao iirc, I was told to assume the log events are in accending order. If that's not the case, this whole search function won't work. If that's not the case, we have to sort all of the lo...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
I do prefer that, but what do @davemarco / @junhaoliao think?
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
Should we also change the name of `FilteredLogEventMapTsType` later? It is also nullable.
