Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Nitpick comments (3)</summary><blockquote> <details> <summary>.github/PULL_REQUEST_TEMPLATE.md (3)</summary><blockquote> `1-14`: **Consider...
coderabbitai[bot] created a comment on a pull request on y-scope/clp-ffi-js
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
nope. I noticed that just before I go to sleep lol
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
yeah I was considering this suggested name and the current one. I find this is more logical.
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
nope. I noticed that just before I go to sleep lol
kirkrodrigues created a comment on a pull request on y-scope/clp-ffi-js
Sorry for the delay in reviewing this. Let's keep further discussions in the PR so that we can all come to a consensus more quickly.
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion // Find the log event whose timestamp is just after `timestamp`. auto first_greater_it{std::upper_bound( ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
std::upper_bound assumes the range is sorted, right? What would happen if the log events aren't in ascending timestamp order? It's technically not impossible and we have seen log files where that's...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Is this related to the change?
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion * Finds the log event, L, where if we assume: * * - the collection of log events is sorted in ascending timestamp order; * - and we insert a marker log event, ...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
std::upper_bound assumes the range is sorted, right? What would happen if the log events aren't in ascending timestamp order? It's technically not impossible and we have seen log files where that's...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
How about `find_nearest_log_event_by_timestamp`? Similar to Marco's original suggestion. Any ambiguity about the name should be resolved by the docstring.
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion /** ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion // How about `NullableLogEventIdx`? EMSCRIPTEN_DECLARE_VAL_TYPE(LogEventIdxTsType); ```
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
_:warning: Potential issue_ **Fix the URL format in FetchContent_Declare.** The URL format is incorrect. The variable name should be properly enclosed in curly braces, and the path separator shou...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summar...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summar...
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
offline discussion's conclusion comes to `get_log_event_idx_with_nearest_timestamp`
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
I agree @davemarco 's suggestion is an improvement
junhaoliao created a comment on an issue on y-scope/clp-ffi-js
> > [@kirkrodrigues](https://github.com/kirkrodrigues) / [@davemarco](https://github.com/davemarco) > > Any objection if we [`npm unpublish`](https://docs.npmjs.com/cli/v9/commands/npm-unpublish) 0...
junhaoliao published a release on y-scope/clp-ffi-js
v0.3.4
## What's Changed * fix: Handle invalid UTF-8 sequences gracefully when converting structured log events to JSON. by @davemarco in https://github.com/y-scope/clp-ffi-js/pull/52 * chore: Upgrade v...