Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
junhaoliao published a release on y-scope/clp-ffi-js
v0.3.2
## What's Changed * Add `LogEventWithFilterData` template class to extend log event classes with processed fields for filtering. by @davemarco in https://github.com/y-scope/clp-ffi-js/pull/32 * U...
junhaoliao pushed 1 commit to main y-scope/clp-ffi-js
- chore: Upgrade version for 0.3.2 release. (#47) 225414a
junhaoliao closed a pull request on y-scope/clp-ffi-js
chore: Upgrade version for 0.3.2 release.
Related: #44 <!-- Set the PR title to a meaningful commit message that: - follows the Conventional Commits specification (https://www.conventionalcommits.org). - is in imperative form. Exampl...
coderabbitai[bot] created a comment on a pull request on y-scope/clp-ffi-js
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
junhaoliao opened a pull request on y-scope/clp-ffi-js
chore: Upgrade version for 0.3.2 release.
<!-- Set the PR title to a meaningful commit message that: - follows the Conventional Commits specification (https://www.conventionalcommits.org). - is in imperative form. Example: fix: Don't ...
junhaoliao pushed 1 commit to main y-scope/clp-ffi-js
- build(cmake): Extract CMake project name and version from package.json. (#45) 476f3c7
junhaoliao closed a pull request on y-scope/clp-ffi-js
build(cmake): Extract CMake project name and version from package.json.
<!-- Set the PR title to a meaningful commit message that: - follows the Conventional Commits specification (https://www.conventionalcommits.org). - is in imperative form. Example: fix: Don't ...
kirkrodrigues created a review on a pull request on y-scope/clp-ffi-js
For the PR title, how about: ``` build(cmake): Extract CMake project name and version from package.json. ``` It's subjective, but I think `build` is a more appropriate type since this chang...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
> I think this point is kind of unrelated to the above and sounds more like it's questioning the motivation of the PR? yes > I think we should keep it. sure. sounds good
junhaoliao created a comment on a pull request on y-scope/clp-ffi-js
This PR is blocking https://github.com/y-scope/yscope-log-viewer/pull/152
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
> but yeah why don't we directly change the metadata in package.json and let cmake sync from it? lol Yep. > with that said, realistically, in this project, those variables are not getting ref...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
and setting cache variables allow docstrings (though it's not like we can't write a comment instead i guess they don't strictly need to be cache variables
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
my understanding of CMake cache variables is that they are like configuration variables that can be overridden by `-DXXX` passed to the `cmake` command. with that said, realistically, in this p...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion if("${PACKAGE_JSON_CONTENT}" MATCHES "\"version\":[ ]*\"([^\"]+)\"") ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion "${CMAKE_MATCH_1}" ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion "${CMAKE_MATCH_1}" ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Why do we need/want to make these cache variables?
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion if("${PACKAGE_JSON_CONTENT}" MATCHES "\"name\":[ ]*\"([^\"]+)\"") ``` To avoid [double-variable expansion](https://cmake.org/cmake/help/latest/command/if.html#variable-expansion).
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
How about `CLP_FFI_JS_PACKAGE_JSON_CONTENT`? (To follow our convention of prefixing local variables with the project name.)
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Nitpick comments (1)</summary><blockquote> <details> <summary>src/clp_ffi_js/constants.hpp (1)</summary><blockquote> Line range hint `30-37...