Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a comment on a pull request on y-scope/clp-ffi-js
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
junhaoliao opened a pull request on y-scope/clp-ffi-js
Rename LogLevel enum values to use PascalCase; prefix enum class specific values with the enum name (fixes #39).
<!-- Set the PR title to a meaningful commit message that: - follows the Conventional Commits specification (https://www.conventionalcommits.org). - is in imperative form. Example: fix: Don't ...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion "${CLP_FFI_JS_PROJECT_NAME}" ```
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Nitpick comments (3)</summary><blockquote> <details> <summary>CMakeLists.txt (3)</summary><blockquote> `18-27`: **Consider using a more rob...
junhaoliao created a comment on a pull request on y-scope/clp-ffi-js
We could also have used [string(JSON ...)](https://cmake.org/cmake/help/latest/command/string.html#json) but that is > Added in version 3.19. We're currently enforcing `cmake_minimum_required(V...
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
_:hammer_and_wrench: Refactor suggestion_ **Add error handling for package.json read operation** The `file(READ ...)` command doesn't verify if the file exists or is readable. Consider adding err...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>🧹 Nitpick comments (1)</summary><blockquote> <details> <summary>CMakeLists.txt (1)</summary><blockquote> `14-23`: **Improve JSON parsing robu...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>🧹 Nitpick comments (1)</summary><blockquote> <details> <summary>CMakeLists.txt (1)</summary><blockquote> `14-23`: **Improve JSON parsing robu...
coderabbitai[bot] created a comment on a pull request on y-scope/clp-ffi-js
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
junhaoliao opened a pull request on y-scope/clp-ffi-js
chore(build): Extract CMake project name and version from `package.json`.
<!-- Set the PR title to a meaningful commit message that: - follows the Conventional Commits specification (https://www.conventionalcommits.org). - is in imperative form. Example: fix: Don't ...
junhaoliao pushed 1 commit to main y-scope/clp-ffi-js
- ci: Add GH workflow for publishing to npm. (#43) beff6ae
junhaoliao closed a pull request on y-scope/clp-ffi-js
ci: Add GH workflow for publishing to npm.
<!-- Set the PR title to a meaningful commit message that: - follows the Conventional Commits specification (https://www.conventionalcommits.org). - is in imperative form. Example: fix: Don't ...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
Gotcha. i'll remove this branching job then
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Ah, the branching strategy in the Java repos is just as a way to stage the release before tagging and releasing it. In those repos, we don't publish the release version update to the main branch, s...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
Sounds good. Shall we also update the workflow `name` and filename to match this?
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
I thought that was a strategy used by our java packages (e.g., logback, log4j1-appenders). With that said, since we cannot overpublish a version on npm, maybe we don't need to create a branch fo...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
if the purpose of the name is to add comments, that just repeat the command. right, we don't need it
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion path: "dist/" if-no-files-found: "error" retention-days: 1 ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Why do we need to create a branch?
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
How about `publish-to-npm`?