Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
junhaoliao created a comment on a pull request on y-scope/clp-ffi-js
Closing this since all features prototyped in this PR has been checked in.
junhaoliao closed a draft pull request on y-scope/clp-ffi-js
Prototype: Add initial code for IRv2 decoder.
<!-- Set the PR title to a meaningful commit message in imperative form. E.g.: linting: Print line and column number of violation (fixes #999). --> The changes in this PR are only to facilita...
junhaoliao created a comment on an issue on y-scope/clp-ffi-js
The issue is also reported in the Emscripten repo: https://github.com/emscripten-core/emsdk/issues/1480
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Nitpick comments (3)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StreamReader.hpp (3)</summary><blockquote> `59-60`: **Enhan...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Nitpick comments (2)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StreamReader.hpp (2)</summary><blockquote> `38-39`: **Add d...
junhaoliao created a comment on a pull request on y-scope/clp-ffi-js
> re: title I think the current title is better. I think adding `StructuredIrStreamReader` to the title is too much detail for someone not familiar with code. Maybe `feat(structured): Add support f...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
Sorry for the confusion. I mean we want to add this at https://github.com/y-scope/clp-ffi-js/blob/d2556b2fb6d986182b247c660244dfbc923e37ea/src/clp_ffi_js/ir/StreamReader.hpp#L99 ``` @throw ClpFfi...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
The suggested wording was from the Coding Guidelines. Might be good to keep that for consistency: https://www.notion.so/yscope/WIP-Coding-Guidelines-9a308b847a5343958ba3cb97a850be66?pvs=4#13504e4d9...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Nitpick comments (2)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StreamReader.hpp (2)</summary><blockquote> `59-60`: **Docum...
junhaoliao created a review on a pull request on y-scope/clp-ffi-js
Added some comments about documentation for the exception behaviour For the PR title, how about ``` feat(StructuredIrStreamReader): Add support for log-level filtering. ```
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
Sorry for the lack of context at https://github.com/y-scope/clp-ffi-js/pull/35#discussion_r1888811976 ```suggestion * @return See `decode_range`. * @throw Propagates `ToStringFunc`'...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
Since the structured one also throws the same error when a message cannot be decoded, let's document this `@throw` in the docstring at https://github.com/y-scope/clp-ffi-js/blob/d2556b2fb6d986182b2...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
This may be deduplicated with `StructuredIrUnitHandler::get_log_level`, but for the sake of simplicity let's leave this for now.
junhaoliao created a review on a pull request on y-scope/clp-ffi-js
Added some comments about documentation for the exception behaviour For the PR title, how about ``` feat(StructuredIrStreamReader): Add support for log-level filtering. ```
junhaoliao created a review on a pull request on y-scope/clp-ffi-js
Added some comments about documentation for the exception behaviour For the PR title, how about ``` feat(StructuredIrStreamReader): Add support for log-level filtering. ```
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Outside diff range and nitpick comments (2)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StreamReader.hpp (2)</summary><blockq...
kirkrodrigues created a review on a pull request on y-scope/clp-ffi-js
For the PR title, how about: ``` feat: Add support for log-level filtering of structured IR streams. ```
junhaoliao created a review on a pull request on y-scope/clp-ffi-js
tested with a clp-ffi-py generated IRv2 file with various log levels. all good except 1. logs can be printed before returning null in `auto StreamReader::generic_decode_range`: https://github.com/...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
* Sure, let's keep `NONE`. * Sure, I guess we could define a new convention. Keep in mind the naming of enum values should be PascalCase.