Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
_:warning: Potential issue_ **Add bounds checking and improve exception safety.** The method needs bounds checking for the timestamp value and should use find() instead of at(). ```diff - aut...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>🧹 Outside diff range and nitpick comments (5)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StructuredIrStreamReader.hpp (1)</sum...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>🧹 Outside diff range and nitpick comments (5)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StructuredIrStreamReader.hpp (1)</sum...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>🧹 Outside diff range and nitpick comments (1)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StreamReader.hpp (1)</summary><blockq...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>🧹 Outside diff range and nitpick comments (1)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StreamReader.hpp (1)</summary><blockq...
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
_:hammer_and_wrench: Refactor suggestion_ **Improve error handling for incomplete IR streams.** Based on the learnings from LinZhihao-723, we should only check for `std::errc::result_out_of_range...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion return generic_decode_range( ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion generic_filter_log_events( ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
I thought I posted this in the previous review but it's not there so I guess I didn't post it or GH lost it before posting. Anyway- This isn't a pair, right? This is the value from the `id_value...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion generic_filter_log_events( ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion return generic_decode_range( ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion * @param filtered_log_event_map * @param log_events * @param use_filter * @param log_event_to_string * @return See `decode_range`. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion template <typename LogEvent, typename ToStringFunc> requires requires(ToStringFunc func, LogEvent const& log_event) { { func(log_event) } -> s...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion * @tparam LogEvent * @tparam ToStringFunc Function to convert a log event into a string. * @param begin_idx ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion * Templated implementation of `decode_range` that uses `log_event_to_string` to convert * `log_event` to a string for the returned result. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion * Templated implementation of `filter_log_events`. ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion * @tparam LogEvent * @param log_level_filter ```
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion template <typename LogEvent> static auto generic_filter_log_events( FilteredLogEventsMap& filtered_log_event_map, LogLevelFilterTsType const& log_l...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion * @param log_events * @param[out] filtered_log_event_map Returns the filtered log events. ``` We use "Returns" for the parameter according to our [internal guidelines]...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
* `generic_filter_log_events` and `generic_decode_range` should be protected, right? * Can we move the implementations after the class declaration?
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StructuredIrStreamReader.cpp (1)</sum...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
I see what you're saying. On the other hand, having two invalid values is kind of messy already. For example, the code to check if a log level is within the valid enum values depends on `cValidLogL...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Right, Marco mentioned that we can only embind an instantiated type, so changing decode_range to use a lambda is probably the cleaner approach.
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
Let's continue the discussion at https://github.com/y-scope/clp-ffi-js/pull/35/files#r1882227286 before we look at the approaches proposed in this thread.
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
1. I was thinking we can declare separate function signatures (one that is specialized for class UnstructuredStreamReader and the other one(s) is/are for class StructuredStreamReader and others. Fo...