Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
junhaoliao created a review on a pull request on y-scope/clp-ffi-js
all good except one opening discussion for the TimestampPattern parameter in the `generic_decode_range` signature.
junhaoliao created a review on a pull request on y-scope/clp-ffi-js
all good except one opening discussion for the TimestampPattern parameter in the `generic_decode_range` signature.
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
@LinZhihao-723 could you help confirm if this is the correct / preferred call sequence to handle End of Stream?
junhaoliao created a review on a pull request on y-scope/clp-ffi-js
overall structure lgtm. I will check the styles and perform a few tests in the evening.
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 2** <details> <summary>🧹 Outside diff range and nitpick comments (2)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/utils.hpp (2)</summary><blockquote> ...
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
_:hammer_and_wrench: Refactor suggestion_ **Consider using std::unordered_set for better performance.** The current implementation uses `std::ranges::find` within a loop, resulting in O(n*m) comp...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/utils.hpp (3)</summary><blockquote> ...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/utils.hpp (3)</summary><blockquote> ...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StructuredIrStreamReader.hpp (1)</sum...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Outside diff range and nitpick comments (1)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StructuredIrUnitHandler.hpp (1)</summ...
junhaoliao closed an issue on y-scope/clp-ffi-js
Increase MAXIMUM_MEMORY to 4GB.
### Request It was observed that the WASM VM can crash when loading a significantly large (512MB input size with 10M log events included) file. By increasing [MAXIMUM_MEMORY](https://emscripten.or...
junhaoliao pushed 1 commit to main y-scope/clp-ffi-js
- fix(build): Increase maximum wasm memory size from 2GB to 4GB (fixes #25). (#38) 01aa3a5
junhaoliao created a comment on a pull request on y-scope/clp-ffi-js
> Do you want to check that this causes no bugs in firefox/chrome? Normally what i have been doing is adding a "dist" folder to clp-ffi-js repo. Then I add the build files into the dist folder. The...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
Right, you got me. i was fuzzily picturing that we could transform the log level during some preprocessing stage of the new formatter, but now with the new syntax implemented i agree that idea does...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
> not straight forward to have a base StreamReader::decode_range() access the derived member variables true. yup i think moving the the shared code to utils.hpp is a good idea. i imagine a templ...
junhaoliao created a comment on a pull request on y-scope/clp-ffi-js
discussed with @davemarco offline and he will review this later in the evening
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
> Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out! <!-- This is an auto-gene...
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
@junhaoliao, I've successfully created the issue to correct the enum property names to PascalCase: [Issue #39](https://github.com/y-scope/clp-ffi-js/issues/39). <details> <summary>🔗 Analysis chain...
coderabbitai[bot] opened an issue on y-scope/clp-ffi-js
Correct enum property names to PascalCase
As discussed in [PR #35](https://github.com/y-scope/clp-ffi-js/pull/35) and [this comment](https://github.com/y-scope/clp-ffi-js/pull/35#discussion_r1842284173), the enum property names in `src/clp...
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
@coderabbit let's open an issue to correct cases of enum property names as PascalCase
junhaoliao created a review comment on a pull request on y-scope/clp-ffi-js
I was thinking we could throw a Not Implemented error in the dummy implementation but forgot the cpp compiler should have caught such unimplemented abstract methods in subclasses at compile time. s...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
I think it's a general C/C++ convention to call it length; that said, it's probably not a bad idea to leave a comment because maybe the reader would confuse "SIZE" for a log level. I also realiz...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Outside diff range and nitpick comments (1)</summary><blockquote> <details> <summary>CMakeLists.txt (1)</summary><blockquote> `69-73`: **Cl...