Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Henry8192 opened a pull request on y-scope/clp-ffi-js
chore: Upgrade version for 0.3.5 release.
<!-- markdownlint-disable MD012 --> # Description Confirmed the "version" value in package.json was updated. # Checklist <!-- Ensure each item below is satisfied and indicate so by inse...
Henry8192 pushed 1 commit to main y-scope/clp-ffi-js
- feat: Add support for finding the log event that's closest to a target timestamp. (#42) f6dedb2
Henry8192 closed a pull request on y-scope/clp-ffi-js
feat: Add support for finding the log event that's closest to a target timestamp.
# Description Adds `getLogEventIndexByTimestamp` API in `clp_ffi_js/ir/StreamReader.cpp` for ClpStreamReader. It returns `null` only if there are no log events. Otherwise, it would search logs in ...
coderabbitai[bot] opened an issue on y-scope/clp-ffi-js
refactor: Rename TypeScript type names to indicate nullability
## Context In PR #42, we discussed renaming TypeScript type names to better indicate their nullability. The change involves: 1. Renaming `FilteredLogEventMapTsType` to include "Nullable" in its n...
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
@Henry8192 Understood, thank you for the clarification. --- <details> <summary>✏️ Learnings added</summary> ``` Learnt from: Henry8192 PR: y-scope/clp-ffi-js#42 File: src/clp_ffi_js/ir/StreamRea...
Henry8192 created a comment on a pull request on y-scope/clp-ffi-js
@junhaoliao I think this PR is ready to be merged.
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>🧹 Nitpick comments (1)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StreamReader.hpp (1)</summary><blockquote> `199-206`: **Sim...
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
_:bulb: Verification agent_ <details> <summary>🧩 Analysis chain</summary> **Verify chronological order assumption.** The implementation assumes log events are sorted by timestamp, but this assum...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>🧹 Nitpick comments (1)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StreamReader.hpp (1)</summary><blockquote> `199-206`: **Sim...
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
```suggestion * - the collection of log events is sorted in chronological order; * - and we insert a marker log event, M, with timestamp `target_ts` into the collection (if log * ...
kirkrodrigues created a review on a pull request on y-scope/clp-ffi-js
For the PR title, how about: ``` feat: Add support for finding the log event that's closest to a target timestamp. ```
kirkrodrigues created a review on a pull request on y-scope/clp-ffi-js
For the PR title, how about: ``` feat: Add support for finding the log event that's closest to a target timestamp. ```
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 0** <details> <summary>🧹 Nitpick comments (1)</summary><blockquote> <details> <summary>src/clp_ffi_js/ir/StreamReader.hpp (1)</summary><blockquote> `196-322`: **Con...
coderabbitai[bot] created a comment on a pull request on y-scope/clp-ffi-js
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
Henry8192 opened a pull request on y-scope/clp-ffi-js
fix(task): show boost download progress during compilation (fixes #56).
<!-- markdownlint-disable MD012 --> # Description Add `set(FETCHCONTENT_QUIET OFF)` when fetching boost, which shows download progress. `set(FETCHCONTENT_QUIET ON)` after download is finished s...
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
In an offline discussion with @junhaoliao, we reach to an agreement that we can doc the assumption, and neglact this corner case. By neglacting this corner case, we can save plenty of resource f...
coderabbitai[bot] created a review comment on a pull request on y-scope/clp-ffi-js
_:bulb: Codebase verification_ **Attention: Log events ordering may not be enforced.** Our investigation shows that the implementation of `generic_find_nearest_log_event_by_timestamp` relies on l...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summar...
coderabbitai[bot] created a review on a pull request on y-scope/clp-ffi-js
**Actionable comments posted: 1** <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summar...
Henry8192 created a review comment on a pull request on y-scope/clp-ffi-js
I agree. Let's roll back to your suggestion.
kirkrodrigues created a review comment on a pull request on y-scope/clp-ffi-js
Would that be straightforward to do given that the log events collection changes based on the active filter? If not, then given how rare the case is (as far as we know), I'm not sure the extra code...