Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
As a side remark, I think it is safe to have local 1D arrays (without allocate / deallocate statements). I think the new intel compiler had issues with local 3D arrays. I am not sure what is the si...
pbartholomew08 created a comment on a pull request on xcompact3d/Incompact3d
Yep, I agree. I've raised a new issue and resolved the conversations.
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Lifted as a new issue
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Lifted as a new issue
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Lifted as a new issue
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Lifted as a new issue
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Lifted as a new issue
pbartholomew08 opened an issue on xcompact3d/Incompact3d
Scope to clean up the stretching code
I realise the code is copy-pasted into the new module so feel free to ignore my suggestions. _Originally posted by @pbartholomew08 in https://github.com/xcompact3d/Incompact3d/pull...
mathrack created a comment on a pull request on xcompact3d/Incompact3d
The scope of the present PR is only to fix the issue linked. In my opinion, it would be best to keep deeper code refactoring / modification for another PR :-)
mathrack pushed 1 commit to fix_ypraf_ibm xcompact3d/Incompact3d
- Add the save attribute to the variables in the stretching module 5fd9d63
slaizet created a comment on a pull request on xcompact3d/Incompact3d
I like the idea of having some stretching-specific parameters to a dedicated module and also a dedicated f90 file for all stretching related subroutines.
slaizet created a comment on an issue on xcompact3d/Incompact3d
okay, so still no luck in having `xi(i,j,k).eq.xf(i,j,k)` so I suggest we comment the "special case" situation in the three spatial direction. That will remove the invalid memory access.
mathrack created a comment on a pull request on xcompact3d/Incompact3d
I think we could also move the inversion5 subroutines inside this new module. However, this is slightly out of the scope, it is probably best to keep the present PR small.
mathrack pushed 1 commit to fix_ypraf_ibm xcompact3d/Incompact3d
- Move variables alpha and beta to the stretching module c62a303
mathrack created a comment on a pull request on xcompact3d/Incompact3d
I think we could also move some stretching-specific parameters to the new module : `alpha`, `beta`, ...
mathrack opened a pull request on xcompact3d/Incompact3d
Move stretching suborutines to a dedicated module and fix undefined y…
…praf values Closing #293
mathrack created a branch on xcompact3d/Incompact3d
fix_ypraf_ibm - Current CPU version of our solver for the Navier-Stokes equations
rfj82982 created a comment on a pull request on xcompact3d/Incompact3d
Still to fix (next PR or 2): - Put back in the install and test the Wind-Turbine - Include in the install and test the particles - Fix the TGV case for single precision (I guess this requir...
rfj82982 created a review comment on a pull request on xcompact3d/Incompact3d
I'll add back the Wind-Turbine in a dedicated PR. Because of many additional files and directories the install bit requires some modifications.